From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59657C3B187 for ; Wed, 12 Feb 2020 00:02:49 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id AC33320724 for ; Wed, 12 Feb 2020 00:02:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="peRaHaSj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC33320724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17784-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 3768 invoked by uid 550); 12 Feb 2020 00:02:42 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 3732 invoked from network); 12 Feb 2020 00:02:41 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581465749; bh=VXj1a+npI+7ydAyG+Owt//6Nop6TGqj0xGSkiZ+iHYA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=peRaHaSjJBWu0RxNWsbg2RkLC4l6xVY/UNgyg4oYdntqHFeDLMDpCQq3ZzzKuUrOA zeKtNvUu0+uN19gu6qqY1w2j4lz2W0GQnIGL18vKQttilbW3vUx2lHkkkV77SlzbVT RktuuaFjkVVQ6c/0oY+eZo3VzmOB0u5pYTbjNi84= Subject: Re: [PATCH v3 7/7] selftests/exec: Add READ_IMPLIES_EXEC tests To: Kees Cook Cc: Ingo Molnar , Hector Marco-Gisbert , Catalin Marinas , Will Deacon , Jason Gunthorpe , Jann Horn , Russell King , x86@kernel.org, kernel-hardening@lists.openwall.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah References: <20200210193049.64362-1-keescook@chromium.org> <20200210193049.64362-8-keescook@chromium.org> <4f8a5036-dc2a-90ad-5fc8-69560a5dd78e@kernel.org> <202002111124.0A334167@keescook> <202002111549.CF18B7B3B@keescook> From: shuah Message-ID: <36e45314-b672-b211-72c5-eef1d48984c0@kernel.org> Date: Tue, 11 Feb 2020 17:02:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <202002111549.CF18B7B3B@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/11/20 4:54 PM, Kees Cook wrote: > On Tue, Feb 11, 2020 at 02:06:53PM -0700, shuah wrote: >> On 2/11/20 12:25 PM, Kees Cook wrote: >>> On Tue, Feb 11, 2020 at 11:11:21AM -0700, shuah wrote: >>>> On 2/10/20 12:30 PM, Kees Cook wrote: >>>>> In order to check the matrix of possible states for handling >>>>> READ_IMPLIES_EXEC across native, compat, and the state of PT_GNU_STACK, >>>>> add tests for these execution conditions. >>>>> >>>>> Signed-off-by: Kees Cook >>>> >>>> No issues for this to go through tip. >>>> >>>> A few problems to fix first. This fails to compile when 32-bit libraries >>>> aren't installed. It should fail the 32-bit part and run other checks. >>> >>> Do you mean the Makefile should detect the missing compat build deps and >>> avoid building them? Testing compat is pretty important to this test, so >>> it seems like missing the build deps causing the build to fail is the >>> correct action here. This is likely true for the x86/ selftests too. >>> >>> What would you like this to do? >>> >> >> selftests/x86 does this already and runs the dependency check in >> x86/Makefile. >> >> >> check_cc.sh:# check_cc.sh - Helper to test userspace compilation support >> Makefile:CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) >> trivial_32bit_program.c -m32) >> Makefile:CAN_BUILD_X86_64 := $(shell ./check_cc.sh $(CC) >> trivial_64bit_program.c) >> Makefile:CAN_BUILD_WITH_NOPIE := $(shell ./check_cc.sh $(CC) >> trivial_program.c -no-pie) >> >> Take a look and see if you can leverage this. > > I did before, and it can certainly be done, but their stuff is somewhat > specific to x86_64/ia32. I'm looking at supporting _all_ compat for any > 64-bit architecture. I can certainly write some similar build tooling, > but the question I have for you is one of coverage: > > If a builder is 64-bit, it needs to be able to produce 32-bit compat > binaries for testing, otherwise the test is incomplete. (i.e. the tests > will only be able to test native behavior and not compat). This doesn't > seem like an "XFAIL" situation to me, and it doesn't seem right to > silently pass. It seems like the build should explicitly fail because > the needed prerequisites are missing. Do you instead want me to just > have it skip building the compat binaries if it can't build them? > Can we do the following: Build and run tests thatc an be built. Skip build and warn that test coverage is incomplete for compat with a strong recommendation on installing 32-bit libraries with some instructions on how to if applicable. thanks, -- Shuah