From: shuah <shuah@kernel.org>
To: "Tobin C. Harding" <tobin@kernel.org>
Cc: Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andy Lutomirski <luto@amacapital.net>,
Daniel Micay <danielmicay@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kernel-hardening@lists.openwall.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v4 0/6] lib/string: Add strscpy_pad() function
Date: Mon, 8 Apr 2019 08:08:45 -0600 [thread overview]
Message-ID: <3d1bc44f-313b-5a58-3492-b706d9510d34@kernel.org> (raw)
In-Reply-To: <20190405015859.32755-1-tobin@kernel.org>
On 4/4/19 7:58 PM, Tobin C. Harding wrote:
> Hi Shua,
>
> Here is the set with cleanup as suggested by Kees on v3.
>
> Configured, built, and tested all modules loaded by
> tools/testing/selftests/lib/*.sh
>
>>>From previous cover letters ...
>
> While doing the testing for strscpy_pad() it was noticed that there is
> duplication in how test modules are being fed to kselftest and also in
> the test modules themselves.
>
> This set makes an attempt at adding a framework to kselftest for writing
> kernel test modules. It also adds a script for use in creating script
> test runners for kselftest. My macro-foo is not great, all criticism
> and suggestions very much appreciated. The design is based on test
> modules lib/test_printf.c, lib/test_bitmap.c, lib/test_xarray.c.
>
> Changes since last version:
>
> - Remove dependency on Bash (thanks Kees)
> - Use oneliner to implement kselftest test runners (thanks Kees)
> - Squash patch that adds kselftest script creator script with patch
> that uses it.
> - Fix typos (thanks Randy)
> - Add Kees' Acked-by tags to all patches
>
> thanks,
> Tobin.
>
>
Hi Tobin,
Thanks for this restructuring work and adding the framework. Thanks Kees
for the reviews.
The patch is series in now in linux-kselftest next for 5.2
thanks,
-- Shuah
next prev parent reply other threads:[~2019-04-08 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:58 [PATCH v4 0/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-05 1:58 ` [PATCH v4 1/6] lib/test_printf: Add empty module_exit function Tobin C. Harding
2019-04-05 1:58 ` [PATCH v4 2/6] kselftest: Add test runner creation script Tobin C. Harding
2019-10-30 12:45 ` Naresh Kamboju
2019-10-30 19:16 ` Kees Cook
2019-04-05 1:58 ` [PATCH v4 3/6] kselftest: Add test module framework header Tobin C. Harding
2019-04-05 1:58 ` [PATCH v4 4/6] lib: Use new kselftest header Tobin C. Harding
2019-04-05 1:58 ` [PATCH v4 5/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-05 1:58 ` [PATCH v4 6/6] lib: Add test module for strscpy_pad Tobin C. Harding
2019-04-07 21:45 ` [PATCH v4 0/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-08 14:08 ` shuah [this message]
2019-04-08 14:59 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d1bc44f-313b-5a58-3492-b706d9510d34@kernel.org \
--to=shuah@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).