From: David Laight <David.Laight@ACULAB.COM>
To: "'Tobin C. Harding'" <tobin@kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Cc: Tycho Andersen <tycho@tycho.ws>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/3] leaking_addresses: Expand tilde in output file name
Date: Wed, 13 Feb 2019 15:56:47 +0000 [thread overview]
Message-ID: <6aed136f16e8451dbcfa97f90c04438f@AcuMS.aculab.com> (raw)
In-Reply-To: <20190207225026.11723-4-tobin@kernel.org>
From: Tobin C. Harding
> Sent: 07 February 2019 22:50
>
> Currently if user passes an output file to the script via
> --output-raw we do not handle expansion of tilde.
>
> Use perl function glob() to expand tilde in output file name.
What happens if glob() returns multiple files?
I'm guessing that it can...
David
> Signed-off-by: Tobin C. Harding <tobin@kernel.org>
> ---
> scripts/leaking_addresses.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
> index ef9e5b2a1614..ce545ca3fb70 100755
> --- a/scripts/leaking_addresses.pl
> +++ b/scripts/leaking_addresses.pl
> @@ -150,7 +150,7 @@ if (!(is_supported_architecture() or $opt_32bit or $page_offset_32bit)) {
> }
>
> if ($output_raw) {
> - open my $fh, '>', $output_raw or die "$0: $output_raw: $!\n";
> + open my $fh, '>', glob($output_raw) or die "$0: $output_raw: $!\n";
> select $fh;
> }
>
> --
> 2.20.1
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-02-13 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 22:50 [PATCH 0/3] Minor bug fixes to leaking_addresses.pl Tobin C. Harding
2019-02-07 22:50 ` [PATCH 1/3] leaking_addresses: Fix calls to dprint Tobin C. Harding
2019-02-07 22:50 ` [PATCH 2/3] leaking_addresses: Completely remove --version flag Tobin C. Harding
2019-02-07 22:50 ` [PATCH 3/3] leaking_addresses: Expand tilde in output file name Tobin C. Harding
2019-02-07 23:35 ` Tycho Andersen
2019-02-09 6:01 ` Tobin C. Harding
2019-02-14 4:13 ` Tobin C. Harding
2019-02-13 15:56 ` David Laight [this message]
2019-02-13 20:30 ` Tobin C. Harding
2019-02-14 9:50 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aed136f16e8451dbcfa97f90c04438f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tobin@kernel.org \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).