From: Daniel Axtens <dja@axtens.net>
To: "Christopher M. Riedl" <cmr@informatik.wtf>,
linuxppc-dev@ozlabs.org, kernel-hardening@lists.openwall.com
Cc: ajd@linux.ibm.com
Subject: Re: [PATCH v5 1/2] powerpc/xmon: Allow listing and clearing breakpoints in read-only mode
Date: Thu, 29 Aug 2019 16:40:03 +1000 [thread overview]
Message-ID: <87ef14v5j0.fsf@dja-thinkpad.axtens.net> (raw)
In-Reply-To: <20190828034613.14750-2-cmr@informatik.wtf>
Hi Chris,
> Read-only mode should not prevent listing and clearing any active
> breakpoints.
I tested this and it works for me:
Tested-by: Daniel Axtens <dja@axtens.net>
> + if (xmon_is_ro || !scanhex(&a)) {
It took me a while to figure out what this line does: as I understand
it, the 'b' command can also be used to install a breakpoint (as well as
bi/bd). If we are in ro mode or if the input after 'b' doesn't scan as a
hex string, print the list of breakpoints instead. Anyway, I'm now
happy with it, so:
Reviewed-by: Daniel Axtens <dja@axtens.net>
Regards,
Daniel
> /* print all breakpoints */
> printf(" type address\n");
> if (dabr.enabled) {
> --
> 2.23.0
next prev parent reply other threads:[~2019-08-29 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 3:46 [PATCH v5 0/2] Restrict xmon when kernel is locked down Christopher M. Riedl
2019-08-28 3:46 ` [PATCH v5 1/2] powerpc/xmon: Allow listing and clearing breakpoints in read-only mode Christopher M. Riedl
2019-08-29 6:40 ` Daniel Axtens [this message]
2019-08-29 12:38 ` Christopher M Riedl
2019-08-28 3:46 ` [PATCH v5 2/2] powerpc/xmon: Restrict when kernel is locked down Christopher M. Riedl
2019-08-29 7:43 ` Daniel Axtens
2019-08-29 12:36 ` Christopher M Riedl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef14v5j0.fsf@dja-thinkpad.axtens.net \
--to=dja@axtens.net \
--cc=ajd@linux.ibm.com \
--cc=cmr@informatik.wtf \
--cc=kernel-hardening@lists.openwall.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).