Kernel-hardening archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] Documentation patch (gcc-plugins kernel)
       [not found] <ebb6d995-a356-bc01-074b-6154a283e299@t-online.de>
@ 2019-08-01 20:14 ` Kees Cook
  2019-08-14 11:29   ` Alexander Popov
  0 siblings, 1 reply; 2+ messages in thread
From: Kees Cook @ 2019-08-01 20:14 UTC (permalink / raw)
  To: Robin Lindner; +Cc: re.emese, kernel-hardening, Alexander Popov, linux-kernel

On Thu, Aug 01, 2019 at 09:30:58AM +0200, Robin Lindner wrote:
> Cleaned documentation comment up. I removed the "TODO" because it was very old.

Hi, please send these patches "normally" (cc maintainers, include lkml,
inline not attachments, etc):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

> ---
>  scripts/gcc-plugins/stackleak_plugin.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/gcc-plugins/stackleak_plugin.c b/scripts/gcc-plugins/stackleak_plugin.c
> index dbd37460c573e..d8ba12c3bb238 100644
> --- a/scripts/gcc-plugins/stackleak_plugin.c
> +++ b/scripts/gcc-plugins/stackleak_plugin.c
> @@ -144,8 +144,6 @@ static unsigned int stackleak_instrument_execute(void)
>  	 *
>  	 * Case in point: native_save_fl on amd64 when optimized for size
>  	 * clobbers rdx if it were instrumented here.
> -	 *
> -	 * TODO: any more special cases?
>  	 */
>  	if (is_leaf &&
>  	    !TREE_PUBLIC(current_function_decl) &&

As to the content of the patch, let's also CC Alexander...

Are there no more special cases?

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Documentation patch (gcc-plugins kernel)
  2019-08-01 20:14 ` [PATCH] Documentation patch (gcc-plugins kernel) Kees Cook
@ 2019-08-14 11:29   ` Alexander Popov
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Popov @ 2019-08-14 11:29 UTC (permalink / raw)
  To: Kees Cook, Robin Lindner; +Cc: re.emese, kernel-hardening, linux-kernel

Hello Kees and Robin,

On 01.08.2019 23:14, Kees Cook wrote:
> On Thu, Aug 01, 2019 at 09:30:58AM +0200, Robin Lindner wrote:
>> Cleaned documentation comment up. I removed the "TODO" because it was very old.
>> ---
>>  scripts/gcc-plugins/stackleak_plugin.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/scripts/gcc-plugins/stackleak_plugin.c b/scripts/gcc-plugins/stackleak_plugin.c
>> index dbd37460c573e..d8ba12c3bb238 100644
>> --- a/scripts/gcc-plugins/stackleak_plugin.c
>> +++ b/scripts/gcc-plugins/stackleak_plugin.c
>> @@ -144,8 +144,6 @@ static unsigned int stackleak_instrument_execute(void)
>>  	 *
>>  	 * Case in point: native_save_fl on amd64 when optimized for size
>>  	 * clobbers rdx if it were instrumented here.
>> -	 *
>> -	 * TODO: any more special cases?
>>  	 */
>>  	if (is_leaf &&
>>  	    !TREE_PUBLIC(current_function_decl) &&
> 
> As to the content of the patch, let's also CC Alexander...
> 
> Are there no more special cases?

I don't know other special cases when we should avoid the instrumentation.

And I can't imagine a method of finding such cases except runtime testing.

Robin, I would better save this comment only removing "TODO" if it matters.

Best regards,
Alexander

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <ebb6d995-a356-bc01-074b-6154a283e299@t-online.de>
2019-08-01 20:14 ` [PATCH] Documentation patch (gcc-plugins kernel) Kees Cook
2019-08-14 11:29   ` Alexander Popov

Kernel-hardening archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernel-hardening/0 kernel-hardening/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernel-hardening kernel-hardening/ https://lore.kernel.org/kernel-hardening \
		kernel-hardening@lists.openwall.com kernel-hardening@archiver.kernel.org
	public-inbox-index kernel-hardening


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.openwall.lists.kernel-hardening


AGPL code for this site: git clone https://public-inbox.org/ public-inbox