From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82500C34056 for ; Wed, 19 Feb 2020 18:28:04 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id DA2F420801 for ; Wed, 19 Feb 2020 18:28:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DMdoPkJf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA2F420801 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17848-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 15361 invoked by uid 550); 19 Feb 2020 18:27:57 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 14314 invoked from network); 19 Feb 2020 18:27:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=DMdoPkJfjI8vEiQ931OXimak2rqeezogGTA8Jz0YUFlSK+iP3iGUiJm8P0zxfSazbl sTLes5Pdhak910J52lP/cGVjDxzDihqkqyUztiFUlwZg0VhXzKO1IB9YGArPtZqB6CV3 5i85IFWDdO9zpfwEZ9XXCunsWgqWEwKKlhfY1B2U5wv6+QD3YcbhFr+s44GC4sg72+rA n2ie3yBEKdehbzyFS5WDKMUNUnSdwc2SvQkZ5DylB/so9f2QssueydxU/mKohLfzAbZz K3OtN1dWSEkKMUwc/C1SbRHw0naFdurKZuH+kXBfdy4MpfLQng5Kl2vAtDn1OZwbvUbU +EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l8bheu//eOsUC2rG1tcM8D2woU+rRRO7+NHd/SAby40=; b=fTVmwEbiIi05zfp6XSzBIkrpSwjrNDjbAyGe7Mj0H5WwdtMgG2fuuFtW4O9y7O0eoi nQj02nyrF5Q8RdKoxIZCqBoA7BhGaUiMS6JtqduCDdccOHBgHbYYuIchpESZLbwmhKVn +dd9jeGDTNEVSrTNIYW2CUEJDogo9n33HiSqCR14CxhEWf2NpJQZ2DjafIKuLktog6NR Vb6hmKumjNIvV2YR2osAZHZHAYFZuZ+DJYGWcNuko+SCDZjpLAAGEH+fn4JWddgbIvL5 1M/6L5e03XcStKqHPIdtHFbwOfR2/yEcBWC4XBrmnUckPAq2bxYgc+zLbRp2VOLh0rK+ ohVw== X-Gm-Message-State: APjAAAV0dRXwnJFdimBb04bhPh7C2weXGYTNO7X3Mt1ddGQVCSzz2KP0 ZVGxTtmxft5wVOHZURdaAzJ62OPDUu9fn+QaAo7+yQ== X-Google-Smtp-Source: APXvYqz43ZWMlwcCQPP90XUO0jIibofgqeEtAm/3NdUy/lBowdl1d7auUgQbzj7b/uQk3jHx8Zbly6t36F7bSB8gUac= X-Received: by 2002:a1f:e784:: with SMTP id e126mr12203230vkh.102.1582136864292; Wed, 19 Feb 2020 10:27:44 -0800 (PST) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200219000817.195049-1-samitolvanen@google.com> <20200219000817.195049-13-samitolvanen@google.com> In-Reply-To: From: Sami Tolvanen Date: Wed, 19 Feb 2020 10:27:33 -0800 Message-ID: Subject: Re: [PATCH v8 12/12] efi/libstub: disable SCS To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Steven Rostedt , Masami Hiramatsu , Mark Rutland , James Morse , Dave Martin , Kees Cook , Laura Abbott , Marc Zyngier , Nick Desaulniers , Jann Horn , Miguel Ojeda , Masahiro Yamada , clang-built-linux , Kernel Hardening , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" On Tue, Feb 18, 2020 at 11:41 PM Ard Biesheuvel wrote: > > On Wed, 19 Feb 2020 at 01:09, Sami Tolvanen wrote: > > > > +# remove SCS flags from all objects in this directory > > +KBUILD_CFLAGS := $(filter-out -ffixed-x18 $(CC_FLAGS_SCS), $(KBUILD_CFLAGS)) > > + > > I don't see why you'd need to remove -ffixed-x18 again here. Not using > x18 anywhere in the kernel is a much more maintainable approach. Sure, I will drop -ffixed-x18 from here in v9. Thanks, Sami