From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35CCCA9EA9 for ; Sat, 19 Oct 2019 00:22:14 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 4680E222C2 for ; Sat, 19 Oct 2019 00:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJhBGhz9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4680E222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17060-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 9268 invoked by uid 550); 19 Oct 2019 00:22:07 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 9250 invoked from network); 19 Oct 2019 00:22:06 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=SJhBGhz9kYlPN0TADnvJp8G2Y17kwQLx8bFgEQxXC4oPBXVPQajIkOkF46KrnCk3Y+ SIhUxsEMZpo0mO71reWB5iYnGBSvSPpnlhJ7SOGmsAzO1r/eCW2htdVksbO0SI9DIYUV omVMOJI5aJQYPBTuWOcF+vN49kJ/Z38IZ5w69/IWpI0dZkus3V70HRJmjzixpNFSsrH7 zFdeP18no8PweXdELrMKy1nvLYeUemGKl7HG8j1bU8GRNXdqGvneSPtLFgWbG2ZCxBd6 JFKB+kpkVv5yQiadF2KjhDCmed79/Dn/ssCkl2cq1nYz+heSuFAzelrZNVV5W1OmMhq6 qcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=PsZxRNCdrNFL3oP5cq5texO90rTzFgvkiQ/qhzuOBRGwI93WZDfKlQxsvL5e8n4xph r0wInzEMDIcelMw0kn8L68qjsu13l8Fdm8HQzQQMQOjFQSsMEsR3MKZs7cxVdvj2KONl 4ciiB6tC03Vhy29HpNwUb6zINqKRxg/xZrA0DviQGd55ITXFMRv9nefynyrcX15LbgdP ptKaHMZ93k2PPNOp5zjpuRtm7InbsJv7urC+MonE7Kso+Sk4JYcD7I0ANzvfy3k+3ts5 i/ZslF3LcD7Enm56V2Ow568cZf7xksDIdVrRx7ljpj2IbUr8n4r0VQ7NNDI0glQLAFbF mBWw== X-Gm-Message-State: APjAAAVhKoCkM0E6MVell8uT+ovCeqMufOub2QN36SXw9fMzEQXBnY51 WQZboCD2mEjWJkIvZ2g30mpYrORwJg63KPYb64E= X-Google-Smtp-Source: APXvYqxT5yYNPjiMSlzwumlj8UjSOAfCmDmgAcpOZOM10R//Skv4aoDktplFaX7g2Ws72X/gbHtxdVXSSeajbRTRouQ= X-Received: by 2002:ac2:55b4:: with SMTP id y20mr7590271lfg.173.1571444515448; Fri, 18 Oct 2019 17:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Miguel Ojeda Date: Sat, 19 Oct 2019 02:21:44 +0200 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers Cc: Sami Tolvanen , Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" On Fri, Oct 18, 2019 at 10:33 PM Nick Desaulniers wrote: > > Sami pointed out to me off thread that __has_attribute would only > check `no_sanitize`, not `shadow-call-stack`. So maybe best to keep > the definition here (include/linux/compiler-clang.h), but wrapped in a > `__has_feature` check so that Clang 6.0 doesn't start complaining. Ah, good point -- agreed! Cheers, Miguel