Kernel-hardening archive on lore.kernel.org
 help / color / Atom feed
From: Allen <allen.lkml@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: Romain Perier <romain.perier@gmail.com>,
	 Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: [PRE-REVIEW PATCH 00/16] Modernize the tasklet API
Date: Wed, 30 Oct 2019 13:50:49 +0530
Message-ID: <CAOMdWSKyAH80dp1JRZ70FarZ4H+=+c8hRDWVOtc=5CXfag9irw@mail.gmail.com> (raw)
In-Reply-To: <201910101531.482D28315@keescook>

Romain,
>
> This is all a normally thankless set of patches, so I'll go out of my
> way to say again: thank you for working on this! I know how tedious it
> can be from when I did timer_struct. :)

 First of all Romain, nice work. I started working on this
set a few months back, but could only carve out limited time.

  I sent out RFC for this sometime in May[1]. And my approach
was a little different when compared to what you have sent on the
list.

 Well, I have pushed my work to github[2], only thing I could
think of as an improvement in your patch set it to break it down
into smaller chunk so that it's easier to review. I have made each
occurrence of tasklet_init() into a commit[3] which I thought would
make it easier to review. I'll leave that decision to you and kees.

Let me know if I could help in any way.

[1] https://www.openwall.com/lists/kernel-hardening/2019/05/06/1
[2] https://github.com/allenpais/tasklet
[3] Sample list of patches:
5d0b728649b6 atm/solos-pci: Convert tasklets to use new tasklet_init API
e5144c3c16d8 atm: Convert tasklets to use new tasklet_init API
71028976d3ed arch/um: Convert tasklets to use new tasklet_init API
c9a39c23b78c xfrm: Convert tasklets to use new tasklet_init API
91d93fe12bbc mac80211: Convert tasklets to use new tasklet_init API
d68f1e9e4531 ipv4: Convert tasklets to use new tasklet_init API
4f9379dcd8ad sound/timer: Convert tasklets to use new tasklet_init API
b4519111b75e drivers/usb: Convert tasklets to use new tasklet_init API
52f04bf54a5a drivers:vt/keyboard: Convert tasklets to use new tasklet_init API
295de7c9812c dma/virt-dma: Convert tasklets to use new tasklet_init API
6c713c83b58f dma/dw: Convert tasklets to use new tasklet_init API
eaaaaba8a4a7 debug:Convert tasklets to use new tasklet_init API
b23f4ff5021b tasklet: prepare to change tasklet API

Thanks,
- Allen

  reply index

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-29 16:30 Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 01/16] tasklet: Prepare to change tasklet callback argument type Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 02/16] crypto: ccp - Prepare to use the new tasklet API Romain Perier
2019-09-30 22:35   ` Kees Cook
2019-09-29 16:30 ` [PRE-REVIEW PATCH 03/16] mmc: renesas_sdhi: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 04/16] net: liquidio: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 05/16] chelsio: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 06/16] net: mvpp2: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 07/16] qed: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 08/16] isdn: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 09/16] scsi: pm8001: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 10/16] scsi: pmcraid: " Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 11/16] treewide: Globally replace tasklet_init() by tasklet_setup() Romain Perier
2019-09-30 22:46   ` Kees Cook
2019-10-01 17:18     ` Romain Perier
2019-10-10 22:30       ` Kees Cook
2019-09-29 16:30 ` [PRE-REVIEW PATCH 12/16] tasklet: Pass tasklet_struct pointer as .data in DECLARE_TASKLET Romain Perier
2019-09-30 22:44   ` Kees Cook
2019-09-29 16:30 ` [PRE-REVIEW PATCH 13/16] tasklet: Pass tasklet_struct pointer to callbacks unconditionally Romain Perier
2019-09-30 22:49   ` Kees Cook
2019-09-29 16:30 ` [PRE-REVIEW PATCH 14/16] tasklet: Remove the data argument from DECLARE_TASKLET() macros Romain Perier
2019-09-30 22:50   ` Kees Cook
2019-09-29 16:30 ` [PRE-REVIEW PATCH 15/16] tasklet: convert callbacks prototype for using struct tasklet_struct * arguments Romain Perier
2019-09-29 16:30 ` [PRE-REVIEW PATCH 16/16] tasklet: Add the new initialization function permanently Romain Perier
2019-09-30 22:52   ` Kees Cook
2019-10-01 17:34     ` Romain Perier
2019-09-30 23:06 ` [PRE-REVIEW PATCH 00/16] Modernize the tasklet API Kees Cook
2019-10-01 17:47   ` Romain Perier
2019-10-10 22:34     ` Kees Cook
2019-10-30  8:20       ` Allen [this message]
2019-11-07  7:29         ` Romain Perier
2019-11-07 21:22           ` Kees Cook

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOMdWSKyAH80dp1JRZ70FarZ4H+=+c8hRDWVOtc=5CXfag9irw@mail.gmail.com' \
    --to=allen.lkml@gmail.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=romain.perier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Kernel-hardening archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kernel-hardening/0 kernel-hardening/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kernel-hardening kernel-hardening/ https://lore.kernel.org/kernel-hardening \
		kernel-hardening@lists.openwall.com
	public-inbox-index kernel-hardening

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.openwall.lists.kernel-hardening


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git