From: Marcin Kozlowski <marcinguy@gmail.com>
To: kernel-hardening@lists.openwall.com
Subject: OOB accesses in ax88179_rx_fixup() (in USB network card driver) - variants
Date: Mon, 21 Mar 2022 10:39:35 +0100 [thread overview]
Message-ID: <CAP6wrbVVK1S+oXHVC6hAs8cRR3XHi31ihBzGHn-rcmE_fUjUVQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
Hi List,
Don't have much experience and knowledge in that area.
Found this:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-linus&id=57bc3d3ae8c14df3ceb4e17d26ddf9eeab304581
Checked out a few drivers code and wondered if anybody did a variant
analysis of this (possibly yes?) However, it seems like Kernel drivers code
for gl620a.c and lg-vl600.c (quick search) don't "Make sure that the bounds
of the metadata array are inside the SKB (and in front of the counter at
the end)."
Example from gl620a.c
https://github.com/torvalds/linux/blob/master/drivers/net/usb/gl620a.c
I think, there is no check for:
/* Make sure that the bounds of the metadata array are inside the SKB
* (and in front of the counter at the end).
*/
if (pkt_cnt * 2 + hdr_off > skb->len)
return 0;
Most likely false positive. Would be great to verify this and learn about
it.
Thanks,
Marcin
[-- Attachment #2: Type: text/html, Size: 2885 bytes --]
next reply other threads:[~2022-03-21 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 9:39 Marcin Kozlowski [this message]
2022-03-26 17:09 ` OOB accesses in ax88179_rx_fixup() (in USB network card driver) - variants Marcin Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAP6wrbVVK1S+oXHVC6hAs8cRR3XHi31ihBzGHn-rcmE_fUjUVQ@mail.gmail.com \
--to=marcinguy@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).