kernel-hardening.lists.openwall.com archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
@ 2022-06-29  6:04 GONG, Ruiqi
  2022-06-29  7:35 ` Christophe Leroy
  0 siblings, 1 reply; 2+ messages in thread
From: GONG, Ruiqi @ 2022-06-29  6:04 UTC (permalink / raw)
  To: Kees Cook, Marco Elver
  Cc: Christophe Leroy, Xiu Jianfeng, kernel-hardening, linuxppc-dev,
	linux-kernel, Gong Ruiqi

Fix the following Sparse warnings that got noticed when the PPC-dev
patchwork was checking another patch (see the link below):

init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?

Which in fact are triggered on all architectures that have
HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
etc).

Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>
---

v2: remove unnecessary #ifdef around the header

 init/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/init/main.c b/init/main.c
index e2490387db2b..eb9bf7c5b28b 100644
--- a/init/main.c
+++ b/init/main.c
@@ -99,6 +99,7 @@
 #include <linux/kcsan.h>
 #include <linux/init_syscalls.h>
 #include <linux/stackdepot.h>
+#include <linux/randomize_kstack.h>
 #include <net/net_namespace.h>
 
 #include <asm/io.h>
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings
  2022-06-29  6:04 [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings GONG, Ruiqi
@ 2022-06-29  7:35 ` Christophe Leroy
  0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2022-06-29  7:35 UTC (permalink / raw)
  To: GONG, Ruiqi, Kees Cook, Marco Elver
  Cc: Xiu Jianfeng, kernel-hardening, linuxppc-dev, linux-kernel



Le 29/06/2022 à 08:04, GONG, Ruiqi a écrit :
> [Vous ne recevez pas souvent de courriers de gongruiqi1@huawei.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix the following Sparse warnings that got noticed when the PPC-dev
> patchwork was checking another patch (see the link below):
> 
> init/main.c:862:1: warning: symbol 'randomize_kstack_offset' was not declared. Should it be static?
> init/main.c:864:1: warning: symbol 'kstack_offset' was not declared. Should it be static?
> 
> Which in fact are triggered on all architectures that have
> HAVE_ARCH_RANDOMIZE_KSTACK_OFFSET support (for instances x86, arm64
> etc).
> 
> Link: https://lore.kernel.org/lkml/e7b0d68b-914d-7283-827c-101988923929@huawei.com/T/#m49b2d4490121445ce4bf7653500aba59eefcb67f
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Xiu Jianfeng <xiujianfeng@huawei.com>
> Signed-off-by: GONG, Ruiqi <gongruiqi1@huawei.com>

Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>

> ---
> 
> v2: remove unnecessary #ifdef around the header
> 
>   init/main.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/init/main.c b/init/main.c
> index e2490387db2b..eb9bf7c5b28b 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -99,6 +99,7 @@
>   #include <linux/kcsan.h>
>   #include <linux/init_syscalls.h>
>   #include <linux/stackdepot.h>
> +#include <linux/randomize_kstack.h>
>   #include <net/net_namespace.h>
> 
>   #include <asm/io.h>
> --
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-29  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29  6:04 [PATCH v2] stack: Declare {randomize_,}kstack_offset to fix Sparse warnings GONG, Ruiqi
2022-06-29  7:35 ` Christophe Leroy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).