From: Dave Hansen <dave.hansen@intel.com>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: "Tobin C . Harding" <me@tobin.cc>,
Tycho Andersen <tycho@tycho.ws>,
kernel-hardening@lists.openwall.com,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm/init: Stop printing pgt_buf addresses
Date: Thu, 9 Apr 2020 15:35:08 -0700 [thread overview]
Message-ID: <cd67ee35-9082-9baf-1d11-598064580f49@intel.com> (raw)
In-Reply-To: <20200409221919.GA1460035@rani.riverdale.lan>
On 4/9/20 3:19 PM, Arvind Sankar wrote:
>> @@ -121,8 +121,6 @@ __ref void *alloc_low_pages(unsigned int num)
>> } else {
>> pfn = pgt_buf_end;
>> pgt_buf_end += num;
>> - printk(KERN_DEBUG "BRK [%#010lx, %#010lx] PGTABLE\n",
>> - pfn << PAGE_SHIFT, (pgt_buf_end << PAGE_SHIFT) - 1);
>> }
>>
>> for (i = 0; i < num; i++) {
>> --
>> 2.24.1
>>
> This was acked by Kees, is it ok for merge?
Independent of the obvious security implications, I don't think I've
ever once gleaned useful information from that message. It's fine by me.
Acked-by: Dave Hansen <dave.hansen@intel.com>
next prev parent reply other threads:[~2020-04-09 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 23:11 [PATCH] x86/mm/init: Stop printing pgt_buf addresses Arvind Sankar
2020-02-29 23:23 ` Kees Cook
2020-04-09 22:19 ` Arvind Sankar
2020-04-09 22:35 ` Dave Hansen [this message]
2020-05-23 1:51 ` Arvind Sankar
2020-05-23 2:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd67ee35-9082-9baf-1d11-598064580f49@intel.com \
--to=dave.hansen@intel.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=me@tobin.cc \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=tycho@tycho.ws \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).