From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC841C433FF for ; Thu, 8 Aug 2019 04:29:41 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 27F2D21743 for ; Thu, 8 Aug 2019 04:29:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27F2D21743 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-16754-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 18346 invoked by uid 550); 8 Aug 2019 04:29:32 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 18312 invoked from network); 8 Aug 2019 04:29:32 -0000 Subject: Re: [PATCH v5 03/10] powerpc: introduce kimage_vaddr to store the kernel base To: Michael Ellerman , , , , , , , , CC: , , , , , , References: <20190807065706.11411-1-yanaijie@huawei.com> <20190807065706.11411-4-yanaijie@huawei.com> <8736idunz8.fsf@concordia.ellerman.id.au> From: Jason Yan Message-ID: Date: Thu, 8 Aug 2019 12:29:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <8736idunz8.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.203] X-CFilter-Loop: Reflected On 2019/8/7 21:03, Michael Ellerman wrote: > Jason Yan writes: >> Now the kernel base is a fixed value - KERNELBASE. To support KASLR, we >> need a variable to store the kernel base. >> >> Signed-off-by: Jason Yan >> Cc: Diana Craciun >> Cc: Michael Ellerman >> Cc: Christophe Leroy >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: Nicholas Piggin >> Cc: Kees Cook >> Reviewed-by: Christophe Leroy >> Reviewed-by: Diana Craciun >> Tested-by: Diana Craciun >> --- >> arch/powerpc/include/asm/page.h | 2 ++ >> arch/powerpc/mm/init-common.c | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h >> index 0d52f57fca04..60a68d3a54b1 100644 >> --- a/arch/powerpc/include/asm/page.h >> +++ b/arch/powerpc/include/asm/page.h >> @@ -315,6 +315,8 @@ void arch_free_page(struct page *page, int order); >> >> struct vm_area_struct; >> >> +extern unsigned long kimage_vaddr; >> + >> #include >> #endif /* __ASSEMBLY__ */ >> #include >> diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c >> index 152ae0d21435..d4801ce48dc5 100644 >> --- a/arch/powerpc/mm/init-common.c >> +++ b/arch/powerpc/mm/init-common.c >> @@ -25,6 +25,8 @@ phys_addr_t memstart_addr = (phys_addr_t)~0ull; >> EXPORT_SYMBOL_GPL(memstart_addr); >> phys_addr_t kernstart_addr; >> EXPORT_SYMBOL_GPL(kernstart_addr); >> +unsigned long kimage_vaddr = KERNELBASE; >> +EXPORT_SYMBOL_GPL(kimage_vaddr); > > The names of the #defines and variables we use for these values are not > very consistent already, but using kimage_vaddr makes it worse I think. > > Isn't this going to have the same value as kernstart_addr, but the > virtual rather than physical address? > Yes, that's true. > If so kernstart_virt_addr would seem better. > OK, I will take kernstart_virt_addr if no better name appears. > cheers > > . >