From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F35C4740A for ; Mon, 9 Sep 2019 12:29:19 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id BDD8D2084D for ; Mon, 9 Sep 2019 12:29:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ssi.gouv.fr header.i=@ssi.gouv.fr header.b="q3oVKRlr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDD8D2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ssi.gouv.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-16887-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 30342 invoked by uid 550); 9 Sep 2019 12:29:11 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 30319 invoked from network); 9 Sep 2019 12:29:11 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ssi.gouv.fr; s=20160407; t=1568032139; bh=XQS2EF2mnNbqj/DprgGZgt8u1Qnlm766iQGzVJeqMHU=; h=Subject:To:CC:References:From:Date:In-Reply-To:From:Subject; b=q3oVKRlrjwqa7gzDcI+Y/JWOteC1KCYyr7kMJ8cHo7vayol0DaSgezX6jfJgD1Odz MC+dLFooSZ4dELBV3NlZPovcCxpSft1PVM2sGbSZNjz72e/518jgyEZHkQiKIoD7B2 vatimaDPPbt/XQchF7Tc5UpgKX2+Fm21Ul7A6rKNG+sSEoB3IUELmkCllInlNrnh1+ mpOYELY1zaXJFTZjEeOqh2RXxIIO83yVg9LfUA8YtKAi/njhOvo3nNgAIS9Je6Z2yW a1vSkCsRUSKlguBpnkZAMzpT/3C58vqLB7b0ejjs+rljlbf+XNS5huUF0LMFFToJNq eyD0rq6cvG2jA== Subject: Re: [PATCH v2 1/5] fs: Add support for an O_MAYEXEC flag on sys_open() To: Aleksa Sarai CC: James Morris , Jeff Layton , Florian Weimer , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , , Alexei Starovoitov , Al Viro , Andy Lutomirski , Christian Heimes , Daniel Borkmann , Eric Chiang , Jan Kara , Jann Horn , Jonathan Corbet , Kees Cook , Matthew Garrett , Matthew Wilcox , Michael Kerrisk , Mimi Zohar , =?UTF-8?Q?Philippe_Tr=c3=a9buchet?= , Scott Shell , Sean Christopherson , Shuah Khan , Song Liu , Steve Dower , Steve Grubb , Thibaut Sautereau , Vincent Strubel , Yves-Alexis Perez , , , , References: <20190906152455.22757-1-mic@digikod.net> <20190906152455.22757-2-mic@digikod.net> <87ef0te7v3.fsf@oldenburg2.str.redhat.com> <75442f3b-a3d8-12db-579a-2c5983426b4d@ssi.gouv.fr> <1fbf54f6-7597-3633-a76c-11c4b2481add@ssi.gouv.fr> <5a59b309f9d0603d8481a483e16b5d12ecb77540.camel@kernel.org> <49e98ece-e85f-3006-159b-2e04ba67019e@ssi.gouv.fr> <20190909115437.jwpyslcdhhvzo7g5@yavin> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: Date: Mon, 9 Sep 2019 14:28:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20190909115437.jwpyslcdhhvzo7g5@yavin> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09/09/2019 13:54, Aleksa Sarai wrote: > On 2019-09-09, Micka=EBl Sala=FCn wrote: >> On 06/09/2019 21:03, James Morris wrote: >>> On Fri, 6 Sep 2019, Jeff Layton wrote: >>> >>>> The fact that open and openat didn't vet unknown flags is really a bug= . >>>> >>>> Too late to fix it now, of course, and as Aleksa points out, we've >>>> worked around that in the past. Now though, we have a new openat2 >>>> syscall on the horizon. There's little need to continue these sorts of >>>> hacks. >>>> >>>> New open flags really have no place in the old syscalls, IMO. >>> >>> Agree here. It's unfortunate but a reality and Linus will reject any su= ch >>> changes which break existing userspace. >> >> Do you mean that adding new flags to open(2) is not possible? > > It is possible, as long as there is no case where a program that works > today (and passes garbage to the unused bits in flags) works with the > change. > > O_TMPFILE was okay because it's actually two flags (one is O_DIRECTORY) > and no working program does file IO to a directory (there are also some > other tricky things done there, I'll admit I don't fully understand it). > > O_EMPTYPATH works because it's a no-op with non-empty path strings, and > empty path strings have always given an error (so no working program > does it today). > > However, O_MAYEXEC will result in programs that pass garbage bits to > potentially get -EACCES that worked previously. > >> As I said, O_MAYEXEC should be ignored if it is not supported by the >> kernel, which perfectly fit with the current open(2) flags behavior, and >> should also behave the same with openat2(2). > > NACK on having that behaviour with openat2(2). -EINVAL on unknown flags > is how all other syscalls work (any new syscall proposed today that > didn't do that would be rightly rejected), and is a quirk of open(2) > which unfortunately cannot be fixed. The fact that *every new O_ flag > needs to work around this problem* should be an indication that this > interface mis-design should not be allowed to infect any more syscalls. It's definitely OK (and a sane interface) to always return -EINVAL for unknown flags with openat2(2) (and other new syscalls). With openat2(2), userland need to handle the case where some flags may be unknown to the kernel (and handling the fact that this syscall may be unknown too). So there is not an issue with openat2(2). However, *userland* should not try to infer possible security restrictions from the O_MAYEXEC flag (then, my use of "ignore" above), which may return -EACCES or not, according to the current running system security policy. Following this reasoning, the current behavior or open(2) is fine for O_MAYEXEC. The openat2(2) strict flag handling (i.e. -EINVAL) is fine too for O_MAYEXEC. > > Note that this point is regardless of the fact that O_MAYEXEC is a > *security* flag -- if userspace wants to have a secure fallback on > old kernels (which is "the right thing" to do) they would have to do > more work than necessary. And programs that don't care don't have to do > anything special. Most of the time this reasoning is good for most security stuff. However, the O_MAYEXEC flag is not a security feature on its own, it is an indication to the kernel to how this file would be used by userland. The *kernel* security policy may tell back to userland if the system security policy allow it or not. Most of the time, Policy Decision Points (PDP) and Policy Enforcement Points (PEP) are in the same software component (e.g. the kernel). Here the kernel is the PDP and userland interpreters are PDP. Obviously, it means that these interpreters must be (sub)part of your TCB (thanks to other security features). > > However with -EINVAL, the programs doing "the right thing" get an easy > -EINVAL check. And programs that don't care can just un-set O_MAYEXEC > and retry. You should be forced to deal with the case where a flag is > not supported -- and this is doubly true of security flags! I'm in favor of doing this for openat2(2) with O_MAYEXEC, but it is not because of the "security purposes" of this flag, as I said above, it is because it is a saner ABI that every syscall should follow. But again, it doesn't change my point about open(2). :) -- Micka=EBl Sala=FCn Les donn=E9es =E0 caract=E8re personnel recueillies et trait=E9es dans le c= adre de cet =E9change, le sont =E0 seule fin d=92ex=E9cution d=92une relati= on professionnelle et s=92op=E8rent dans cette seule finalit=E9 et pour la = dur=E9e n=E9cessaire =E0 cette relation. Si vous souhaitez faire usage de v= os droits de consultation, de rectification et de suppression de vos donn= =E9es, veuillez contacter contact.rgpd@sgdsn.gouv.fr. Si vous avez re=E7u c= e message par erreur, nous vous remercions d=92en informer l=92exp=E9diteur= et de d=E9truire le message. The personal data collected and processed dur= ing this exchange aims solely at completing a business relationship and is = limited to the necessary duration of that relationship. If you wish to use = your rights of consultation, rectification and deletion of your data, pleas= e contact: contact.rgpd@sgdsn.gouv.fr. If you have received this message in= error, we thank you for informing the sender and destroying the message.