From: Alexander Popov <alex.popov@linux.com>
To: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Cc: Emese Revfy <re.emese@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Laura Abbott <labbott@redhat.com>, Jann Horn <jannh@google.com>,
Alexander Potapenko <glider@google.com>,
kernel-hardening@lists.openwall.comArd Biesheuvel
<ard.biesheuvel@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 1/2] gcc-plugins: structleak: Generalize to all variable types
Date: Tue, 12 Mar 2019 02:05:27 +0300 [thread overview]
Message-ID: <fe87367b-f196-e8b0-6028-6378b65e5240@linux.com> (raw)
In-Reply-To: <20190212180441.15340-2-keescook@chromium.org>
Hello Kees, hello everyone,
On 12.02.2019 21:04, Kees Cook wrote:
> Building with CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL should give the
> kernel complete initialization coverage of all stack variables passed
> by reference, including padding (see lib/test_stackinit.c).
I would like to note that new STRUCTLEAK_BYREF_ALL initializes *less* stack
variables than STACKINIT, that was introduced earlier:
https://www.openwall.com/lists/kernel-hardening/2019/01/23/3
Citing the patches:
- the STACKINIT plugin "attempts to perform unconditional initialization of all
stack variables";
- the STRUCTLEAK_BYREF_ALL feature "gives the kernel complete initialization
coverage of all stack variables passed by reference".
I.e. stack variables not passed by reference are not initialized by
STRUCTLEAK_BYREF_ALL.
Kees, what do you think about adding such cases to your lib/test_stackinit.c?
This simple example demonstrates the idea:
diff --git a/lib/test_stackinit.c b/lib/test_stackinit.c
index 13115b6..f9ef313 100644
--- a/lib/test_stackinit.c
+++ b/lib/test_stackinit.c
@@ -320,9 +320,18 @@ static noinline __init int leaf_switch_2_none(unsigned long sp, bool fill,
DEFINE_TEST_DRIVER(switch_1_none, uint64_t, SCALAR);
DEFINE_TEST_DRIVER(switch_2_none, uint64_t, SCALAR);
+struct x {
+ int x1;
+ int x2;
+ int x3;
+};
+
static int __init test_stackinit_init(void)
{
unsigned int failures = 0;
+ struct x _x;
+
+ printk("uninitialized struct fields sum: %d\n", _x.x1 + _x.x2 + _x.x3);
#define test_scalars(init) do { \
failures += test_u8_ ## init (); \
Kernel output:
root@vm:~# insmod /lib/modules/5.0.0+/kernel/lib/test_stackinit.ko
[ 40.534622] uninitialized struct fields sum: -727800841
Best regards,
Alexander
next prev parent reply other threads:[~2019-03-11 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 18:04 [PATCH 0/2] gcc-plugins: structleak: Generalize to all variable types Kees Cook
2019-02-12 18:04 ` [PATCH 1/2] " Kees Cook
2019-02-28 20:27 ` Arnd Bergmann
2019-03-02 9:04 ` Ard Biesheuvel
2019-03-02 15:43 ` Kees Cook
2019-03-02 22:15 ` Arnd Bergmann
2019-03-04 17:32 ` Kees Cook
2019-03-11 23:05 ` Alexander Popov [this message]
2019-03-13 19:01 ` Kees Cook
2019-02-12 18:04 ` [PATCH 2/2] lib: Introduce test_stackinit module Kees Cook
2019-03-11 10:52 ` Geert Uytterhoeven
2019-04-23 22:42 ` Kees Cook
2019-02-15 17:38 ` [PATCH 0/2] gcc-plugins: structleak: Generalize to all variable types Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe87367b-f196-e8b0-6028-6378b65e5240@linux.com \
--to=alex.popov@linux.com \
--cc=ard.biesheuvel@linaro.org \
--cc=glider@google.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.comArd \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).