From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Yann Droneaud <ydroneaud@opteya.com>,
David Laight <David.Laight@aculab.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Stephen Kitt <steve@sk2.org>,
Nitin Gote <nitin.r.gote@intel.com>,
"jannh@google.com" <jannh@google.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Thu, 25 Jul 2019 19:46:53 -0700 [thread overview]
Message-ID: <ffcdd323f2f325fc9e9f2e17e1795ddaddeccd33.camel@perches.com> (raw)
In-Reply-To: <201907251301.E1E32DCCCE@keescook>
On Thu, 2019-07-25 at 13:03 -0700, Kees Cook wrote:
> On Wed, Jul 24, 2019 at 10:08:57AM -0700, Linus Torvalds wrote:
> > On Wed, Jul 24, 2019 at 6:09 AM Rasmus Villemoes
> > <linux@rasmusvillemoes.dk> wrote:
> > > The kernel's snprintf() does not behave in a non-standard way, at least
> > > not with respect to its return value.
> >
> > Note that the kernels snprintf() *does* very much protect against the
> > overflow case - not by changing the return value, but simply by having
> >
> > /* Reject out-of-range values early. Large positive sizes are
> > used for unknown buffer sizes. */
> > if (WARN_ON_ONCE(size > INT_MAX))
> > return 0;
> >
> > at the very top.
> >
> > So you can't actually overflow in the kernel by using the repeated
> >
> > offset += vsnprintf( .. size - offset ..);
> >
> > model.
> >
> > Yes, it's the wrong thing to do, but it is still _safe_.
>
> Actually, perhaps we should add this test to strscpy() too?
Doesn't seem to have a reason not to be added
but maybe it's better to add another WARN_ON_ONCE.
> diff --git a/lib/string.c b/lib/string.c
[]
> @@ -182,7 +182,7 @@ ssize_t strscpy(char *dest, const char *src, size_t count)
> size_t max = count;
> long res = 0;
>
> - if (count == 0)
> + if (count == 0 || count > INT_MAX)
> return -E2BIG;
>
> #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
>
next prev parent reply other threads:[~2019-07-26 2:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 0:38 [PATCH 0/2] string: Add stracpy and stracpy_pad Joe Perches
2019-07-23 0:38 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Joe Perches
2019-07-23 4:35 ` Andrew Morton
2019-07-23 4:42 ` Joe Perches
2019-07-23 21:29 ` Kees Cook
2019-07-23 6:55 ` Rasmus Villemoes
2019-07-23 15:41 ` David Laight
2019-07-23 15:50 ` Joe Perches
2019-07-23 21:34 ` Kees Cook
2019-07-24 12:05 ` Yann Droneaud
2019-07-24 13:09 ` Rasmus Villemoes
2019-07-24 17:08 ` Linus Torvalds
2019-07-25 20:03 ` Kees Cook
2019-07-26 2:46 ` Joe Perches [this message]
2019-07-23 21:36 ` Kees Cook
2019-07-24 11:40 ` Joe Perches
2019-07-23 0:38 ` [PATCH 2/2] kernel-doc: core-api: Include string.h into core-api Joe Perches
2019-07-23 21:28 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffcdd323f2f325fc9e9f2e17e1795ddaddeccd33.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nitin.r.gote@intel.com \
--cc=steve@sk2.org \
--cc=torvalds@linux-foundation.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).