From: Shuyi Cheng <chengshuyi@linux.alibaba.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak caused by obj->kconfig
Date: Sun, 11 Jul 2021 09:27:20 +0800 [thread overview]
Message-ID: <03eac45f-cc30-f9d3-ab36-892e5757e01b@linux.alibaba.com> (raw)
In-Reply-To: <20210710144248.GA1931@kadam>
On 7/10/21 10:42 PM, Dan Carpenter wrote:
> On Fri, Jul 09, 2021 at 10:47:53AM +0800, Shuyi Cheng wrote:
>> When obj->kconfig is NULL, ERR_PTR(-ENOMEM) should not be returned
>> directly, err=-ENOMEM should be set, and then goto out.
>>
>
> The commit message needs to say what the problem is that the patch is
> fixing. Here is a better commit message:
>
> [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak on error
>
> If the strdup() fails then we need to call bpf_object__close(obj) to
> avoid a resource leak.
>
> Add a Fixes tag as well.
Agree, Thanks.
After Andrii reviews the patch, I will resend a new patch.
regards,
Shuyi
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2021-07-11 1:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 2:47 [PATCH bpf-next v3 0/2] libbpf: Introduce 'btf_custom_path' to 'bpf_obj_open_opts' Shuyi Cheng
2021-07-09 2:47 ` [PATCH bpf-next v3 1/2] " Shuyi Cheng
2021-07-12 23:53 ` Andrii Nakryiko
2021-07-09 2:47 ` [PATCH bpf-next v3 2/2] libbpf: Fix the possible memory leak caused by obj->kconfig Shuyi Cheng
2021-07-10 14:42 ` Dan Carpenter
2021-07-11 1:27 ` Shuyi Cheng [this message]
2021-07-13 0:01 ` [PATCH bpf-next v3 0/2] libbpf: Introduce 'btf_custom_path' to 'bpf_obj_open_opts' Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03eac45f-cc30-f9d3-ab36-892e5757e01b@linux.alibaba.com \
--to=chengshuyi@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).