* [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call for rx1_symbol_clk
@ 2020-07-20 16:29 ` Colin King
2020-07-21 0:49 ` Alim Akhtar
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-07-20 16:29 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Vinod Koul, Seungwon Jeon, Kiwoong Kim,
Alim Akhtar
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The check to see if the call to devm_clk_get on rx1_symbol_clk is checking
the wrong variable, this looks like a copy-paste error. Fix this to check
phy->rx1_symbol instead of phy->rx0_symbol.
Addresses-Coverity: ("Copy-paste error")
Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c
index 43ef77d1d96c..9832599a0283 100644
--- a/drivers/phy/samsung/phy-samsung-ufs.c
+++ b/drivers/phy/samsung/phy-samsung-ufs.c
@@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy)
}
phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
- if (IS_ERR(phy->rx0_symbol_clk)) {
+ if (IS_ERR(phy->rx1_symbol_clk)) {
dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
return PTR_ERR(phy->rx1_symbol_clk);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call for rx1_symbol_clk
2020-07-20 16:29 ` [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call for rx1_symbol_clk Colin King
@ 2020-07-21 0:49 ` Alim Akhtar
0 siblings, 0 replies; 2+ messages in thread
From: Alim Akhtar @ 2020-07-21 0:49 UTC (permalink / raw)
To: 'Colin King', 'Kishon Vijay Abraham I',
'Vinod Koul', 'Seungwon Jeon',
'Kiwoong Kim'
Cc: kernel-janitors, linux-kernel
Hello Colin,
> -----Original Message-----
> From: Colin King <colin.king@canonical.com>
> Sent: 20 July 2020 22:00
> To: Kishon Vijay Abraham I <kishon@ti.com>; Vinod Koul <vkoul@kernel.org>;
> Seungwon Jeon <essuuj@gmail.com>; Kiwoong Kim
> <kwmad.kim@samsung.com>; Alim Akhtar <alim.akhtar@samsung.com>
> Cc: kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call
> for rx1_symbol_clk
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The check to see if the call to devm_clk_get on rx1_symbol_clk is checking the
> wrong variable, this looks like a copy-paste error. Fix this to check
> phy->rx1_symbol instead of phy->rx0_symbol.
>
This fix is already posted by Gustavo [1]
[1] https://lkml.org/lkml/2020/7/20/617
Thanks!
> Addresses-Coverity: ("Copy-paste error")
> Fixes: bca21e930451 ("phy: samsung-ufs: add UFS PHY driver for samsung SoC")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/phy/samsung/phy-samsung-ufs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/samsung/phy-samsung-ufs.c
> b/drivers/phy/samsung/phy-samsung-ufs.c
> index 43ef77d1d96c..9832599a0283 100644
> --- a/drivers/phy/samsung/phy-samsung-ufs.c
> +++ b/drivers/phy/samsung/phy-samsung-ufs.c
> @@ -147,7 +147,7 @@ static int samsung_ufs_phy_symbol_clk_init(struct
> samsung_ufs_phy *phy)
> }
>
> phy->rx1_symbol_clk = devm_clk_get(phy->dev, "rx1_symbol_clk");
> - if (IS_ERR(phy->rx0_symbol_clk)) {
> + if (IS_ERR(phy->rx1_symbol_clk)) {
> dev_err(phy->dev, "failed to get rx1_symbol_clk clock\n");
> return PTR_ERR(phy->rx1_symbol_clk);
> }
> --
> 2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-21 0:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200720162959epcas5p1bf43c0c67ee0c098428b78b2d0ded2db@epcas5p1.samsung.com>
2020-07-20 16:29 ` [PATCH][next] phy: samsung-ufs: fix check on failed devm_clk_get call for rx1_symbol_clk Colin King
2020-07-21 0:49 ` Alim Akhtar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).