* Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit
@ 2020-06-14 11:31 Markus Elfring
2020-06-14 11:31 ` Markus Elfring
2020-06-14 11:31 ` Markus Elfring
0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2020-06-14 11:31 UTC (permalink / raw)
To: Navid Emamdoost, dri-devel
Cc: Qiushi Wu, Tomeu Vizoso, David Airlie, kernel-janitors,
Kangjie Lu, linux-kernel, Steven Price, Navid Emamdoost,
Alyssa Rosenzweig, Stephen McCamant
> in panfrost_job_hw_submit, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
…
> @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
> job, js, jc_head);
>
> job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> + pm_runtime_put_sync_autosuspend(pfdev->dev);
> + return;
> }
…
Perhaps use the label “put_sync” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit
2020-06-14 11:31 [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit Markus Elfring
2020-06-14 11:31 ` Markus Elfring
@ 2020-06-14 11:31 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-06-14 11:31 UTC (permalink / raw)
To: Navid Emamdoost, dri-devel
Cc: Qiushi Wu, Tomeu Vizoso, David Airlie, kernel-janitors,
Kangjie Lu, linux-kernel, Steven Price, Navid Emamdoost,
Alyssa Rosenzweig, Stephen McCamant
> in panfrost_job_hw_submit, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
…
> @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
> job, js, jc_head);
>
> job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> + pm_runtime_put_sync_autosuspend(pfdev->dev);
> + return;
> }
…
Perhaps use the label “put_sync” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit
2020-06-14 11:31 [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit Markus Elfring
@ 2020-06-14 11:31 ` Markus Elfring
2020-06-14 11:31 ` Markus Elfring
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2020-06-14 11:31 UTC (permalink / raw)
To: Navid Emamdoost, dri-devel
Cc: Qiushi Wu, Tomeu Vizoso, David Airlie, kernel-janitors,
Kangjie Lu, linux-kernel, Steven Price, Navid Emamdoost,
Alyssa Rosenzweig, Stephen McCamant
> in panfrost_job_hw_submit, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
…
> @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
> job, js, jc_head);
>
> job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> + pm_runtime_put_sync_autosuspend(pfdev->dev);
> + return;
> }
…
Perhaps use the label “put_sync” instead?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-14 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-14 11:31 [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit Markus Elfring
2020-06-14 11:31 ` Markus Elfring
2020-06-14 11:31 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).