kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
@ 2020-05-30  7:29 Christophe JAILLET
  2020-06-10  2:41 ` Martin K. Petersen
  0 siblings, 1 reply; 6+ messages in thread
From: Christophe JAILLET @ 2020-05-30  7:29 UTC (permalink / raw)
  To: linux, jejb, martin.petersen
  Cc: Christophe JAILLET, kernel-janitors, linux-scsi,
	linux-arm-kernel, linux-kernel

The dev_id used in 'request_irq()' and 'free_irq()' should match.
So use 'host' in both cases.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/scsi/arm/powertec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/arm/powertec.c b/drivers/scsi/arm/powertec.c
index 772a13e5fd91..723b80084498 100644
--- a/drivers/scsi/arm/powertec.c
+++ b/drivers/scsi/arm/powertec.c
@@ -354,7 +354,7 @@ static int powertecscsi_probe(struct expansion_card *ec,
 		goto out_free;
 
 	ret = request_irq(ec->irq, powertecscsi_intr,
-			  0, "powertec", info);
+			  0, "powertec", host);
 	if (ret) {
 		printk("scsi%d: IRQ%d not free: %d\n",
 		       host->host_no, ec->irq, ret);
-- 
2.25.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
  2020-05-30  7:29 [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()' Christophe JAILLET
@ 2020-06-10  2:41 ` Martin K. Petersen
  2020-06-10  5:35   ` Christophe JAILLET
  0 siblings, 1 reply; 6+ messages in thread
From: Martin K. Petersen @ 2020-06-10  2:41 UTC (permalink / raw)
  To: jejb, linux, Christophe JAILLET
  Cc: linux-arm-kernel, kernel-janitors, linux-kernel,
	Martin K . Petersen, linux-scsi

On Sat, 30 May 2020 09:29:33 +0200, Christophe JAILLET wrote:

> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> So use 'host' in both cases.

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq()
      https://git.kernel.org/mkp/scsi/c/af7b415a1ebf

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
  2020-06-10  2:41 ` Martin K. Petersen
@ 2020-06-10  5:35   ` Christophe JAILLET
  2020-06-10 11:53     ` Martin K. Petersen
  2020-06-26  3:59     ` [PATCH V2] " Christophe JAILLET
  0 siblings, 2 replies; 6+ messages in thread
From: Christophe JAILLET @ 2020-06-10  5:35 UTC (permalink / raw)
  To: Martin K. Petersen, jejb, linux
  Cc: kernel-janitors, linux-kernel, linux-arm-kernel, linux-scsi

Le 10/06/2020 à 04:41, Martin K. Petersen a écrit :
> On Sat, 30 May 2020 09:29:33 +0200, Christophe JAILLET wrote:
>
>> The dev_id used in 'request_irq()' and 'free_irq()' should match.
>> So use 'host' in both cases.
> Applied to 5.8/scsi-queue, thanks!
>
> [1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq()
>        https://git.kernel.org/mkp/scsi/c/af7b415a1ebf
>
Please revert, the patch is bogus, as spotted by Russell King - ARM 
Linux admin <linux@armlinux.org.uk>.
See [1].

I'll try to send the correct fix by this week-end.

CJ

[1]: https://marc.info/?l=linux-scsi&m\x159083184215730&w=4

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
  2020-06-10  5:35   ` Christophe JAILLET
@ 2020-06-10 11:53     ` Martin K. Petersen
  2020-06-26  3:59     ` [PATCH V2] " Christophe JAILLET
  1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-06-10 11:53 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: linux-scsi, Martin K. Petersen, jejb, kernel-janitors, linux,
	linux-kernel, linux-arm-kernel


Christophe,

>> [1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq()
>>        https://git.kernel.org/mkp/scsi/c/af7b415a1ebf
>>
> Please revert,

Dropped (x2).

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH V2] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
  2020-06-10  5:35   ` Christophe JAILLET
  2020-06-10 11:53     ` Martin K. Petersen
@ 2020-06-26  3:59     ` Christophe JAILLET
  2020-07-03  4:03       ` Martin K. Petersen
  1 sibling, 1 reply; 6+ messages in thread
From: Christophe JAILLET @ 2020-06-26  3:59 UTC (permalink / raw)
  To: linux, jejb, martin.petersen
  Cc: Christophe JAILLET, kernel-janitors, linux-scsi,
	linux-arm-kernel, linux-kernel

The dev_id used in 'request_irq()' and 'free_irq()' should match.
So use 'info' in both cases.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
V2: update free_irq instead of request_irq in order not to obviously break
    code
---
 drivers/scsi/arm/powertec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/arm/powertec.c b/drivers/scsi/arm/powertec.c
index 772a13e5fd91..d99ef014528e 100644
--- a/drivers/scsi/arm/powertec.c
+++ b/drivers/scsi/arm/powertec.c
@@ -378,7 +378,7 @@ static int powertecscsi_probe(struct expansion_card *ec,
 
 	if (info->info.scsi.dma != NO_DMA)
 		free_dma(info->info.scsi.dma);
-	free_irq(ec->irq, host);
+	free_irq(ec->irq, info);
 
  out_release:
 	fas216_release(host);
-- 
2.25.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH V2] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()'
  2020-06-26  3:59     ` [PATCH V2] " Christophe JAILLET
@ 2020-07-03  4:03       ` Martin K. Petersen
  0 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2020-07-03  4:03 UTC (permalink / raw)
  To: linux, Christophe JAILLET, jejb
  Cc: linux-arm-kernel, kernel-janitors, linux-scsi,
	Martin K . Petersen, linux-kernel

On Fri, 26 Jun 2020 05:59:48 +0200, Christophe JAILLET wrote:

> The dev_id used in 'request_irq()' and 'free_irq()' should match.
> So use 'info' in both cases.

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: powertec: Fix different dev_id between request_irq() and free_irq()
      https://git.kernel.org/mkp/scsi/c/d179f7c76324

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-07-03  4:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30  7:29 [PATCH] scsi: powertec: Fix different dev_id between 'request_irq()' and 'free_irq()' Christophe JAILLET
2020-06-10  2:41 ` Martin K. Petersen
2020-06-10  5:35   ` Christophe JAILLET
2020-06-10 11:53     ` Martin K. Petersen
2020-06-26  3:59     ` [PATCH V2] " Christophe JAILLET
2020-07-03  4:03       ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).