From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Fri, 19 Jun 2020 15:26:32 +0000 Subject: Re: [PATCH] coccinelle: api/kstrdup: fix coccinelle position Message-Id: <0f221342-cd9c-04d2-da01-f86574d3de34@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Denis Efremov , Coccinelle , Gilles Muller , Julia Lawall , Masahiro Yamada , Michal Marek , Nicolas Palix Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org > There is a typo in rule r2. Position p1 should be attached to kzalloc() call. I find such a suggestion reasonable for an implementation detail. I would find an other patch subject clearer. How do you think about to move the specification “@p1” out of SmPL disjunctions? Regards, Markus