From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
linux-power <linux-power@fi.rohmeurope.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"colin.king@canonical.com" <colin.king@canonical.com>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] regulator: bd9576: Fix uninitializes variable may_have_irqs
Date: Tue, 22 Jun 2021 15:30:52 +0000 [thread overview]
Message-ID: <10409fa6738f3a9371985121b2838734249c1c3e.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20210622144730.22821-1-colin.king@canonical.com>
On Tue, 2021-06-22 at 15:47 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The boolean variable may_have_irqs is not ininitialized and is
> only being set to true in the case where chip is
> ROHM_CHIP_TYPE_BD9576.
> Fix this by ininitialized may_have_irqs to false.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: e7bf1fa58c46 ("regulator: bd9576: Support error reporting")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/regulator/bd9576-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/bd9576-regulator.c
> b/drivers/regulator/bd9576-regulator.c
> index 8b54d88827be..e16c3727db7a 100644
> --- a/drivers/regulator/bd9576-regulator.c
> +++ b/drivers/regulator/bd9576-regulator.c
> @@ -897,7 +897,7 @@ static int bd957x_probe(struct platform_device
> *pdev)
> {
> int i;
> unsigned int num_reg_data;
> - bool vout_mode, ddr_sel, may_have_irqs;
> + bool vout_mode, ddr_sel, may_have_irqs = false;
> struct regmap *regmap;
> struct bd957x_data *ic_data;
> struct regulator_config config = { 0 };
Thanks a lot!
Acked-by: Matti Vaittinen <
matti.vaittinen@fi.rohmeurope.com>
Best Regards
Matti Vaittinen
next prev parent reply other threads:[~2021-06-22 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:47 [PATCH][next] regulator: bd9576: Fix uninitializes variable may_have_irqs Colin King
2021-06-22 15:30 ` Vaittinen, Matti [this message]
2021-06-23 16:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10409fa6738f3a9371985121b2838734249c1c3e.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).