From: Julia Lawall <Julia.Lawall@lip6.fr>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] add missing of_node_put
Date: Wed, 21 Oct 2015 20:41:35 +0000 [thread overview]
Message-ID: <1445460100-26727-1-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1444480254-14399-1-git-send-email-Julia.Lawall@lip6.fr>
The various for_each device_node iterators performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.
The complete semantic patch that fixes this problem is
(http://coccinelle.lip6.fr):
// <smpl>
@r@
local idexpression n;
expression e1,e2;
iterator name for_each_node_by_name, for_each_node_by_type,
for_each_compatible_node, for_each_matching_node,
for_each_matching_node_and_match, for_each_child_of_node,
for_each_available_child_of_node, for_each_node_with_property;
iterator i;
statement S;
expression list [n1] es;
@@
(
(
for_each_node_by_name(n,e1) S
|
for_each_node_by_type(n,e1) S
|
for_each_compatible_node(n,e1,e2) S
|
for_each_matching_node(n,e1) S
|
for_each_matching_node_and_match(n,e1,e2) S
|
for_each_child_of_node(e1,n) S
|
for_each_available_child_of_node(e1,n) S
|
for_each_node_with_property(n,e1) S
)
&
i(es,n,...) S
)
@@
local idexpression r.n;
iterator r.i;
expression e;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
@@
local idexpression r.n;
iterator r.i;
expression e;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
@@
local idexpression r.n;
iterator r.i;
expression e;
identifier l;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? goto l;
)
...
}
...
l: ... when != n// </smpl>
---
drivers/clk/clk-scpi.c | 1 +
drivers/clk/clk-si5351.c | 17 ++++++++++-------
drivers/clk/clk.c | 4 ++++
drivers/clk/imx/clk-imx27.c | 4 +++-
drivers/clk/imx/clk-imx31.c | 4 +++-
5 files changed, 21 insertions(+), 9 deletions(-)
next prev parent reply other threads:[~2015-10-21 20:41 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 12:30 [PATCH 0/5] add missing of_node_put Julia Lawall
2015-10-10 12:30 ` [PATCH 1/5] backlight: 88pm860x_bl: " Julia Lawall
2015-10-13 8:15 ` Lee Jones
2015-10-10 12:30 ` [PATCH 2/5] power_supply: charger-manager: " Julia Lawall
2015-10-12 2:20 ` Krzysztof Kozlowski
2015-10-15 8:56 ` Sebastian Reichel
2015-10-10 12:30 ` [PATCH 3/5] ARM: shmobile: R-Mobile: " Julia Lawall
2015-10-12 0:16 ` Simon Horman
2015-10-12 7:18 ` Geert Uytterhoeven
2015-10-12 7:24 ` Julia Lawall
2015-10-12 7:26 ` Geert Uytterhoeven
2015-10-12 7:29 ` Thomas Petazzoni
2015-10-12 7:30 ` Geert Uytterhoeven
2015-10-10 12:30 ` [PATCH 4/5] regulator: of: " Julia Lawall
2015-10-12 0:33 ` Krzysztof Kozlowski
2015-10-12 5:35 ` Julia Lawall
2015-10-12 12:44 ` Julia Lawall
2015-10-12 12:58 ` Krzysztof Kozlowski
2018-02-12 12:09 ` Applied "regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_mat Mark Brown
2015-10-10 12:30 ` [PATCH 5/5] arm: add missing of_node_put Julia Lawall
2015-10-10 21:02 ` Arnd Bergmann
2015-10-10 21:08 ` Thomas Petazzoni
2015-10-10 21:12 ` Julia Lawall
2015-10-10 21:10 ` Julia Lawall
2015-10-10 21:15 ` Arnd Bergmann
2015-10-10 21:41 ` [PATCH 5/5 v2] " Julia Lawall
2015-10-21 20:41 ` Julia Lawall [this message]
2015-10-21 20:41 ` [PATCH 1/5] clk: " Julia Lawall
2015-10-21 23:13 ` Stephen Boyd
2015-10-22 5:52 ` Julia Lawall
2015-10-21 20:41 ` [PATCH 2/5] clk: si5351: " Julia Lawall
2015-10-21 23:14 ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 3/5] clk: imx27: " Julia Lawall
2015-10-21 23:15 ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 4/5] clk: imx31: " Julia Lawall
2015-10-21 23:15 ` Stephen Boyd
2015-10-21 20:41 ` [PATCH 5/5] clk: scpi: " Julia Lawall
2015-10-21 23:17 ` Stephen Boyd
2015-10-22 9:21 ` Sudeep Holla
2015-11-26 17:29 ` Sudeep Holla
2015-12-01 0:28 ` Stephen Boyd
2015-12-01 0:29 ` Stephen Boyd
2015-12-21 16:39 ` [PATCH 0/5] " Julia Lawall
2015-12-21 16:39 ` [PATCH 1/5] pinctrl-tegra: " Julia Lawall
2015-12-22 12:44 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 2/5] pinctrl: sirf: " Julia Lawall
2015-12-22 12:45 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 3/5] pinctrl: sh-pfc: " Julia Lawall
2015-12-21 20:46 ` Laurent Pinchart
2015-12-22 12:47 ` Linus Walleij
2015-12-22 13:23 ` Geert Uytterhoeven
2015-12-21 16:39 ` [PATCH 4/5] pinctrl: rockchip: " Julia Lawall
2015-12-21 21:20 ` Heiko Stübner
2015-12-22 12:48 ` Linus Walleij
2015-12-21 16:39 ` [PATCH 5/5] pinctrl: mediatek: " Julia Lawall
2015-12-22 12:49 ` Linus Walleij
2018-05-23 19:07 ` [PATCH 0/5] " Julia Lawall
2018-05-23 19:07 ` [PATCH 1/5] pinctrl: at91-pio4: " Julia Lawall
2018-05-24 7:59 ` Ludovic Desroches
2018-05-24 8:30 ` Linus Walleij
2018-05-23 19:07 ` [PATCH 2/5] phy: " Julia Lawall
2018-05-23 19:07 ` [PATCH 3/5] soc: ti: knav_dma: " Julia Lawall
2018-05-23 19:07 ` [PATCH 4/5] pci/hotplug/pnv-php: " Julia Lawall
2018-05-23 21:50 ` Bjorn Helgaas
2018-05-23 19:07 ` [PATCH 5/5] drm/rockchip: lvds: " Julia Lawall
2018-06-16 12:24 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445460100-26727-1-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).