From: Julia Lawall <Julia.Lawall@inria.fr>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: eugene.volanschi@inria.fr, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org
Subject: [PATCH] iommu/virtio: reverse arguments to list_add
Date: Tue, 05 May 2020 18:47:47 +0000
Message-ID: <1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr> (raw)
Elsewhere in the file, there is a list_for_each_entry with
&vdev->resv_regions as the second argument, suggesting that
&vdev->resv_regions is the list head. So exchange the
arguments on the list_add call to put the list head in the
second argument.
Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---
drivers/iommu/virtio-iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index d5cac4f46ca5..4e1d11af23c8 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -453,7 +453,7 @@ static int viommu_add_resv_mem(struct viommu_endpoint *vdev,
if (!region)
return -ENOMEM;
- list_add(&vdev->resv_regions, ®ion->list);
+ list_add(®ion->list, &vdev->resv_regions);
return 0;
}
next reply index
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:47 Julia Lawall [this message]
2020-05-06 9:35 ` Jean-Philippe Brucker
2020-05-08 15:31 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr \
--to=julia.lawall@inria.fr \
--cc=eugene.volanschi@inria.fr \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Kernel-Janitors Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/kernel-janitors/0 kernel-janitors/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 kernel-janitors kernel-janitors/ https://lore.kernel.org/kernel-janitors \
kernel-janitors@vger.kernel.org
public-inbox-index kernel-janitors
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.kernel-janitors
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git