From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Kiwoong Kim <kwmad.kim@samsung.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-samsung-soc@vger.kernel.org,
Avri Altman <avri.altman@wdc.com>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check
Date: Tue, 30 Jun 2020 03:23:04 +0000 [thread overview]
Message-ID: <159348736490.22355.10176976047581563338.b4-ty@oracle.com> (raw)
In-Reply-To: <20200626105133.GF314359@mwanda>
On Fri, 26 Jun 2020 13:51:33 +0300, Dan Carpenter wrote:
> The "head" pointer can't be NULL because it points to an address in
> the middle of a ufs_hba struct. Looking at this code, probably someone
> would wonder if the intent was to check whether "hba" is NULL, but "hba"
> isn't NULL and the check can just be removed.
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/b7a80dac0f1f
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-06-30 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200626105156epcas5p191d18d66af6bd09a10635559461c0bc0@epcas5p1.samsung.com>
2020-06-26 10:51 ` [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check Dan Carpenter
2020-06-27 17:33 ` Alim Akhtar
2020-06-27 17:54 ` Dan Carpenter
2020-06-28 1:56 ` Alim Akhtar
2020-06-30 3:23 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159348736490.22355.10176976047581563338.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).