From: Mimi Zohar <zohar@kernel.org>
To: James Morris <jmorris@namei.org>,
Colin King <colin.king@canonical.com>,
Mimi Zohar <zohar@linux.ibm.com>
Cc: "Serge E . Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] integrity: remove redundant initialization of variable ret
Date: Mon, 27 Jul 2020 20:57:56 +0000 [thread overview]
Message-ID: <1595883476.4841.167.camel@kernel.org> (raw)
In-Reply-To: <alpine.LRH.2.21.2007280405340.18670@namei.org>
On Tue, 2020-07-28 at 04:05 +1000, James Morris wrote:
> On Wed, 1 Jul 2020, Colin King wrote:
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The variable ret is being initialized with a value that is never read
> > and it is being updated later with a new value. The initialization is
> > redundant and can be removed.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > security/integrity/digsig_asymmetric.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/digsig_asymmetric.c b/security/integrity/digsig_asymmetric.c
> > index 4e0d6778277e..cfa4127d0518 100644
> > --- a/security/integrity/digsig_asymmetric.c
> > +++ b/security/integrity/digsig_asymmetric.c
> > @@ -79,7 +79,7 @@ int asymmetric_verify(struct key *keyring, const char *sig,
> > struct public_key_signature pks;
> > struct signature_v2_hdr *hdr = (struct signature_v2_hdr *)sig;
> > struct key *key;
> > - int ret = -ENOMEM;
> > + int ret;
>
> Assuming Mimi will grab this.
>
>
> Acked-by: James Morris <jamorris@linux.microsoft.com>
Yes, thank you for the reminder.
Mimi
prev parent reply other threads:[~2020-07-27 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:46 [PATCH] integrity: remove redundant initialization of variable ret Colin King
2020-07-27 18:05 ` James Morris
2020-07-27 20:57 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595883476.4841.167.camel@kernel.org \
--to=zohar@kernel.org \
--cc=colin.king@canonical.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).