From: Douglas Gilbert <dgilbert@interlog.com>
To: Markus Elfring <Markus.Elfring@web.de>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] lib/scatterlist: Fix memory leak in sgl_alloc_order()
Date: Sun, 20 Sep 2020 19:35:18 +0000 [thread overview]
Message-ID: <1608a0b7-6960-afce-aa39-6785036b01e0@interlog.com> (raw)
In-Reply-To: <e69e9865-a599-5bd9-95b1-7d57c7e2e90c@web.de>
On 2020-09-20 1:09 p.m., Markus Elfring wrote:
>> Noticed that when sgl_alloc_order() failed with order > 0 that
>> free memory on my machine shrank. That function shouldn't call
>> sgl_free() on its error path since that is only correct when
>> order=0 .
>
> * Would an imperative wording become helpful for the change description?
No passive tense there. Or do you mean usage like: "Go to hell" or
"Fix memory leak in ..."? I studied French and Latin at school; at a
guess, my mother tongue got its grammar from the former. My mother
taught English grammar and the term "imperative wording" rings no
bells in my grammatical education. Google agrees with me.
Please define: "imperative wording".
> * How do you think about to add the tag “Fixes” to the commit message?r
In the workflow I'm used to, others (closer to LT) make that decision.
Why waste my time?
> * Will an other patch subject be more appropriate?
Twas testing a 6 GB allocation with said function on my 8 GB laptop.
It failed and free told me 5 GB had disappeared (and
'cat /sys/kernel/debug/kmemleak' told me _nothing_). Umm, it is
potentially a HUGE f@#$ing memory LEAK! Best to call a spade a spade.
Doug Gilbert
next parent reply other threads:[~2020-09-20 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e69e9865-a599-5bd9-95b1-7d57c7e2e90c@web.de>
2020-09-20 19:35 ` Douglas Gilbert [this message]
[not found] ` <d8eb3d0e-52e2-1dab-ac02-774fdbd9c18c@web.de>
2020-09-21 0:57 ` [PATCH] lib/scatterlist: Fix memory leak in sgl_alloc_order() Douglas Gilbert
2020-09-21 8:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608a0b7-6960-afce-aa39-6785036b01e0@interlog.com \
--to=dgilbert@interlog.com \
--cc=Markus.Elfring@web.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).