* [PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()'
@ 2021-06-12 12:53 Christophe JAILLET
2021-06-14 19:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2021-06-12 12:53 UTC (permalink / raw)
To: manishc, rahulv, GR-Linux-NIC-Dev, davem, kuba, amit.salecha
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.
Fixes: e87ad5539343 ("netxen: support pci error handlers")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
index 7e6bac85495d..344ea1143454 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
@@ -1602,6 +1602,8 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
free_netdev(netdev);
err_out_free_res:
+ if (NX_IS_REVISION_P3(pdev->revision))
+ pci_disable_pcie_error_reporting(pdev);
pci_release_regions(pdev);
err_out_disable_pdev:
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()'
2021-06-12 12:53 [PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()' Christophe JAILLET
@ 2021-06-14 19:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-14 19:20 UTC (permalink / raw)
To: Christophe JAILLET
Cc: manishc, rahulv, GR-Linux-NIC-Dev, davem, kuba, amit.salecha,
netdev, linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 12 Jun 2021 14:53:12 +0200 you wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: e87ad5539343 ("netxen: support pci error handlers")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> [...]
Here is the summary with links:
- netxen_nic: Fix an error handling path in 'netxen_nic_probe()'
https://git.kernel.org/netdev/net/c/49a10c7b1762
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-14 19:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 12:53 [PATCH] netxen_nic: Fix an error handling path in 'netxen_nic_probe()' Christophe JAILLET
2021-06-14 19:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).