From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-kernel@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Tomas Henzl <thenzl@redhat.com>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
kernel-janitors@vger.kernel.org, linux-scsi@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>
Subject: Re: [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check
Date: Tue, 15 Jun 2021 23:48:52 -0400 [thread overview]
Message-ID: <162381524896.11966.10253531415079746073.b4-ty@oracle.com> (raw)
In-Reply-To: <YMCJKgykDYtyvY44@mwanda>
On Wed, 9 Jun 2021 12:26:02 +0300, Dan Carpenter wrote:
> The "mrioc->intr_info" pointer can't be NULL, but if it could then the
> second iteration through the loop would Oops. Let's delete the
> confusing and impossible NULL check.
Applied to 5.14/scsi-queue, thanks!
[1/2] scsi: mpi3mr: delete unnecessary NULL check
https://git.kernel.org/mkp/scsi/c/d46bdecd9f3c
[2/2] scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
https://git.kernel.org/mkp/scsi/c/2938bedd0efa
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-06-16 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 9:26 [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check Dan Carpenter
2021-06-09 9:27 ` [PATCH 2/2] scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr() Dan Carpenter
2021-06-10 3:01 ` [PATCH 1/2] scsi: mpi3mr: delete unnecessary NULL check Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162381524896.11966.10253531415079746073.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=hare@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).