From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65798C48BDF for ; Sun, 20 Jun 2021 20:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D1516101D for ; Sun, 20 Jun 2021 20:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbhFTUfn (ORCPT ); Sun, 20 Jun 2021 16:35:43 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:57085 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbhFTUfl (ORCPT ); Sun, 20 Jun 2021 16:35:41 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8383B240008; Sun, 20 Jun 2021 20:33:26 +0000 (UTC) From: Alexandre Belloni To: Colin King , linux-rtc@vger.kernel.org, Alessandro Zummo Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] rtc: v3020: remove redundant initialization of variable retval Date: Sun, 20 Jun 2021 22:33:23 +0200 Message-Id: <162422118505.1090685.17421473715592582970.b4-ty@bootlin.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609120050.185746-1-colin.king@canonical.com> References: <20210609120050.185746-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Wed, 9 Jun 2021 13:00:50 +0100, Colin King wrote: > The variable retval is being initialized with a value that is never read, > it is being updated later on. The assignment is redundant and can be > removed. Applied, thanks! [1/1] rtc: v3020: remove redundant initialization of variable retval commit: fc3c335226a92f69aa01061e66b60ace88475dd3 Best regards, -- Alexandre Belloni