* [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
@ 2021-06-19 13:50 Dan Carpenter
2021-06-21 17:02 ` Guvenc Gulce
2021-06-21 19:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-06-19 13:50 UTC (permalink / raw)
To: Karsten Graul, Guvenc Gulce
Cc: David S. Miller, Jakub Kicinski, linux-s390, netdev, kernel-janitors
These functions return negative ENODATA but the minus sign was left out
in the tests.
Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/smc/smc_stats.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/smc/smc_stats.c b/net/smc/smc_stats.c
index 614013e3b574..e80e34f7ac15 100644
--- a/net/smc/smc_stats.c
+++ b/net/smc/smc_stats.c
@@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)
continue;
if (!skip_serv) {
rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv);
- if (rc_srv && rc_srv != ENODATA)
+ if (rc_srv && rc_srv != -ENODATA)
break;
} else {
skip_serv = 0;
}
rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv);
- if (rc_clnt && rc_clnt != ENODATA) {
+ if (rc_clnt && rc_clnt != -ENODATA) {
skip_serv = 1;
break;
}
- if (rc_clnt == ENODATA && rc_srv == ENODATA)
+ if (rc_clnt == -ENODATA && rc_srv == -ENODATA)
break;
}
mutex_unlock(&net->smc.mutex_fback_rsn);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
2021-06-19 13:50 [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats() Dan Carpenter
@ 2021-06-21 17:02 ` Guvenc Gulce
2021-06-21 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Guvenc Gulce @ 2021-06-21 17:02 UTC (permalink / raw)
To: Dan Carpenter, Karsten Graul
Cc: David S. Miller, Jakub Kicinski, linux-s390, netdev, kernel-janitors
On 19/06/2021 15:50, Dan Carpenter wrote:
> These functions return negative ENODATA but the minus sign was left out
> in the tests.
>
> Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> net/smc/smc_stats.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/smc/smc_stats.c b/net/smc/smc_stats.c
> index 614013e3b574..e80e34f7ac15 100644
> --- a/net/smc/smc_stats.c
> +++ b/net/smc/smc_stats.c
> @@ -393,17 +393,17 @@ int smc_nl_get_fback_stats(struct sk_buff *skb, struct netlink_callback *cb)
> continue;
> if (!skip_serv) {
> rc_srv = smc_nl_get_fback_details(skb, cb, k, is_srv);
> - if (rc_srv && rc_srv != ENODATA)
> + if (rc_srv && rc_srv != -ENODATA)
> break;
> } else {
> skip_serv = 0;
> }
> rc_clnt = smc_nl_get_fback_details(skb, cb, k, !is_srv);
> - if (rc_clnt && rc_clnt != ENODATA) {
> + if (rc_clnt && rc_clnt != -ENODATA) {
> skip_serv = 1;
> break;
> }
> - if (rc_clnt == ENODATA && rc_srv == ENODATA)
> + if (rc_clnt == -ENODATA && rc_srv == -ENODATA)
> break;
> }
> mutex_unlock(&net->smc.mutex_fback_rsn);
Acked-by: Guvenc Gulce <guvenc@linux.ibm.com>
Thanks for preparing the fix.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
2021-06-19 13:50 [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats() Dan Carpenter
2021-06-21 17:02 ` Guvenc Gulce
@ 2021-06-21 19:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-21 19:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: kgraul, guvenc, davem, kuba, linux-s390, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 19 Jun 2021 16:50:21 +0300 you wrote:
> These functions return negative ENODATA but the minus sign was left out
> in the tests.
>
> Fixes: f0dd7bf5e330 ("net/smc: Add netlink support for SMC fallback statistics")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> net/smc/smc_stats.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- [net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats()
https://git.kernel.org/netdev/net-next/c/1a1100d53f12
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-21 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-19 13:50 [PATCH net-next] net/smc: Fix ENODATA tests in smc_nl_get_fback_stats() Dan Carpenter
2021-06-21 17:02 ` Guvenc Gulce
2021-06-21 19:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).