From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: linux-scsi@vger.kernel.org, Colin King <colin.king@canonical.com>,
Hannes Reinecke <hare@suse.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
Date: Tue, 29 Jun 2021 00:10:06 -0400 [thread overview]
Message-ID: <162493961194.16549.11024974338962781518.b4-ty@oracle.com> (raw)
In-Reply-To: <20210621151727.20667-1-colin.king@canonical.com>
On Mon, 21 Jun 2021 16:17:27 +0100, Colin King wrote:
> The shifting of the u8 integer returned fom ahc_inb(ahc, port+3) by
> 24 bits to the left will be promoted to a 32 bit signed int and then
> sign-extended to a u64. In the event that the top bit of the u8
> is set then all then all the upper 32 bits of the u64 end up as
> also being set because of the sign-extension. Fix this by
> casting the u8 values to a u64 before the 24 bit left shift.
>
> [...]
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
https://git.kernel.org/mkp/scsi/c/332a9dd1d86f
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-06-29 4:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 15:17 [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8 Colin King
2021-06-23 1:17 ` Martin K. Petersen
2021-06-29 4:10 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162493961194.16549.11024974338962781518.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).