From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
kernel-janitors@vger.kernel.org,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
mpi3mr-linuxdrv.pdl@broadcom.com,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Subject: Re: [PATCH] scsi: mpi3mr: clean up mpi3mr_print_ioc_info()
Date: Tue, 12 Oct 2021 16:35:08 -0400 [thread overview]
Message-ID: <163407081305.28503.18198344074370197576.b4-ty@oracle.com> (raw)
In-Reply-To: <20210916132605.GF25094@kili>
On Thu, 16 Sep 2021 16:26:05 +0300, Dan Carpenter wrote:
> This function is more complicated than necessary.
>
> If we change from scnprintf() to snprintf() that let's us remove the
> if bytes_wrote < sizeof(protocol) checks. Also we can use
> bytes_wrote ? "," : "" to print the comma and remove the separate
> if statement and the "is_string_nonempty" variable.
>
> [...]
Applied to 5.16/scsi-queue, thanks!
[1/1] scsi: mpi3mr: clean up mpi3mr_print_ioc_info()
https://git.kernel.org/mkp/scsi/c/76a4f7cc5973
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-10-12 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 13:26 [PATCH] scsi: mpi3mr: clean up mpi3mr_print_ioc_info() Dan Carpenter
2021-10-05 3:54 ` Martin K. Petersen
2021-10-12 20:35 ` Martin K. Petersen [this message]
2021-10-13 8:25 ` Dan Carpenter
2021-10-13 8:33 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163407081305.28503.18198344074370197576.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).