From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: mathieu.poirier@linaro.org, james.quinlan@broadcom.com,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
ohad@wizery.com
Cc: kernel-janitors@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle_vdev()'
Date: Fri, 15 Oct 2021 12:22:13 -0500 [thread overview]
Message-ID: <163431847249.251657.11309404044031278395.b4-ty@linaro.org> (raw)
In-Reply-To: <e6d0dad6620da4fdf847faa903f79b735d35f262.1630755377.git.christophe.jaillet@wanadoo.fr>
On Sat, 4 Sep 2021 13:37:32 +0200, Christophe JAILLET wrote:
> If 'copy_dma_range_map() fails, the memory allocated for 'rvdev' will leak.
> Move the 'copy_dma_range_map()' call after the device registration so
> that 'rproc_rvdev_release()' can be called to free some resources.
>
> Also, branch to the error handling path if 'copy_dma_range_map()' instead
> of a direct return to avoid some other leaks.
>
> [...]
Applied, thanks!
[1/1] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle_vdev()'
commit: 0374a4ea7269645c46c3eb288526ea072fa19e79
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
prev parent reply other threads:[~2021-10-15 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 11:37 [PATCH] remoteproc: Fix a memory leak in an error handling path in 'rproc_handle_vdev()' Christophe JAILLET
2021-09-09 18:01 ` Mathieu Poirier
2021-09-09 20:23 ` Jim Quinlan
2021-10-15 17:22 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163431847249.251657.11309404044031278395.b4-ty@linaro.org \
--to=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=james.quinlan@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).