From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
andrey.utkin@corp.bluecherry.net, anton@corp.bluecherry.net,
maintainers@bluecherrydvr.com, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: Re: [PATCH] media: tw5864: Simplify 'tw5864_finidev()'
Date: Tue, 19 Oct 2021 11:35:44 +0100 [thread overview]
Message-ID: <163463974453.1853916.7698473612617245785@Monstersaurus> (raw)
In-Reply-To: <189d4fd72db8707cb495e3a29ab7a276e07f62a0.1634373552.git.christophe.jaillet@wanadoo.fr>
Quoting Christophe JAILLET (2021-10-16 09:40:29)
> Some resources are allocated with 'pci_request_regions()', so use
> 'pci_release_regions()' to free them, instead of a verbose
> 'release_mem_region()'.
And the driver was even already using pci_release_regions() in
tw5864_initdev(), so indeed this makes it more consistent too.
I'm curious that tw5864_initdev() calls pci_enable_device() (and
pci_disable_device in it's error path), while tw5864_finidev() doesn't.
Would you like to submit a patch to fix that on top of this one? or should I?
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> There is no point in calling 'devm_kfree()'. The corresponding resource is
> managed, so it will be fried automatically.
Indeed.
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/media/pci/tw5864/tw5864-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/tw5864/tw5864-core.c b/drivers/media/pci/tw5864/tw5864-core.c
> index 23d3cae54a5d..fee3b7711901 100644
> --- a/drivers/media/pci/tw5864/tw5864-core.c
> +++ b/drivers/media/pci/tw5864/tw5864-core.c
> @@ -333,11 +333,9 @@ static void tw5864_finidev(struct pci_dev *pci_dev)
>
> /* release resources */
> iounmap(dev->mmio);
> - release_mem_region(pci_resource_start(pci_dev, 0),
> - pci_resource_len(pci_dev, 0));
> + pci_release_regions(pci_dev);
>
> v4l2_device_unregister(&dev->v4l2_dev);
> - devm_kfree(&pci_dev->dev, dev);
> }
>
> static struct pci_driver tw5864_pci_driver = {
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-10-19 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 8:40 [PATCH] media: tw5864: Simplify 'tw5864_finidev()' Christophe JAILLET
2021-10-19 10:35 ` Kieran Bingham [this message]
2021-10-19 17:46 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163463974453.1853916.7698473612617245785@Monstersaurus \
--to=kieran.bingham@ideasonboard.com \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=anton@corp.bluecherry.net \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).