From: Richard Weinberger <richard@nod.at>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: chengzhihao1 <chengzhihao1@huawei.com>,
Colin Ian King <colin.king@canonical.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ubifs: Remove a redundant null check on pointer lp
Date: Tue, 22 Jun 2021 09:26:19 +0200 (CEST) [thread overview]
Message-ID: <1855987833.142283.1624346779725.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20210622064419.GJ1901@kadam>
----- Ursprüngliche Mail -----
> Ugh... I'm so sorry. My patch was clearly wrong. I've tried before to
No need to worry. :)
> add a Smatch check which warns about duplicative NULL checks, but I
> think this gives me a new idea to try. Hopefully, it will prevent this
> in the future.
Sounds great!
Thanks,
//richard
next prev parent reply other threads:[~2021-06-22 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 15:22 [PATCH] ubifs: Remove a redundant null check on pointer lp Colin King
2021-06-22 2:38 ` Zhihao Cheng
2021-06-22 6:44 ` Dan Carpenter
2021-06-22 7:26 ` Richard Weinberger [this message]
2021-06-22 7:24 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1855987833.142283.1624346779725.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=chengzhihao1@huawei.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).