archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <>
To: Denis Efremov <>,
	Coccinelle <>,
	Gilles Muller <>,
	Julia Lawall <>,
	Masahiro Yamada <>,
	Michal Marek <>,
	Nicolas Palix <>
Subject: Re: [PATCH] coccinelle: api: add device_attr_show script
Date: Mon, 15 Jun 2020 14:04:39 +0000	[thread overview]
Message-ID: <> (raw)

> +// Confidence: High

Would you like to add any suggestion for a possible patch message?

> +virtual report
> +virtual org
> +virtual context
> +virtual patch

+virtual report, org, context, patch

Is such a SmPL code variant more succinct?

> +ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	<...
> +*	return snprintf@p(...);
> +	...>
> +}

I suggest to reconsider the selection of the SmPL nest construct.

Can the construct “<+... … ...+>” become relevant here?

Would you like to consider any further software design consequences
around the safe application of the asterisk functionality in rules
for the semantic patch language?


             reply	other threads:[~2020-06-15 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15 14:04 Markus Elfring [this message]
2020-06-15 15:43 ` [PATCH] coccinelle: api: add device_attr_show script Julia Lawall
2020-06-15 16:27   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).