From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Carstens Date: Thu, 25 Jun 2015 11:37:12 +0000 Subject: Re: [PATCH] s390/process: Delete an unnecessary check before the function call "kfree" Message-Id: <20150625113712.GB4069@osiris> List-Id: References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <558B1799.8040003@users.sourceforge.net> <558BD1B4.4030209@bfs.de> In-Reply-To: <558BD1B4.4030209@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: walter harms Cc: SF Markus Elfring , Martin Schwidefsky , linux390@de.ibm.com, linux-s390@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Thu, Jun 25, 2015 at 12:02:28PM +0200, walter harms wrote: > > Am 24.06.2015 22:48, schrieb SF Markus Elfring: > > From: Markus Elfring > > Date: Wed, 24 Jun 2015 22:40:30 +0200 > > > > The kfree() function tests whether its argument is NULL and then > > returns immediately. Thus the test around the call is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > arch/s390/kernel/process.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c > > index dc5edc2..22e6448 100644 > > --- a/arch/s390/kernel/process.c > > +++ b/arch/s390/kernel/process.c > > @@ -81,8 +81,7 @@ void release_thread(struct task_struct *dead_task) > > > > void arch_release_task_struct(struct task_struct *tsk) > > { > > - if (tsk->thread.vxrs) > > - kfree(tsk->thread.vxrs); > > + kfree(tsk->thread.vxrs); > > } This code will be changed soon anyway. So it would be rather pointless to apply your patch now. Thanks anyway! > > int copy_thread(unsigned long clone_flags, unsigned long new_stackp, > maybe the intention was to check tsk != NULL ? No.