From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruno =?UTF-8?B?UHLDqW1vbnQ=?= Date: Mon, 29 Jun 2015 06:34:47 +0000 Subject: Re: [PATCH] HID-picoLCD: Deletion of unnecessary checks before three function calls Message-Id: <20150629083447.68b6cd0c@pluto.restena.lu> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546CD595.3090508@users.sourceforge.net> <558FE090.8030307@users.sourceforge.net> In-Reply-To: <558FE090.8030307@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: SF Markus Elfring , Jiri Kosina Cc: linux-input@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall On Sun, 28 Jun 2015 13:54:56 +0200 SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 19 Nov 2014 18:30:22 +0100 > >=20 > > The functions backlight_device_unregister(), lcd_device_unregister() and > > rc_unregister_device() test whether their argument is NULL and then > > return immediately. Thus the test around the call is not needed. > >=20 > > This issue was detected by using the Coccinelle software. > >=20 > > Signed-off-by: Markus Elfring > > --- > > drivers/hid/hid-picolcd_backlight.c | 3 +-- > > drivers/hid/hid-picolcd_cir.c | 3 +-- > > drivers/hid/hid-picolcd_lcd.c | 3 +-- > > 3 files changed, 3 insertions(+), 6 deletions(-) > >=20 > > diff --git a/drivers/hid/hid-picolcd_backlight.c b/drivers/hid/hid-pico= lcd_backlight.c > > index a32c5f8..808807a 100644 > > --- a/drivers/hid/hid-picolcd_backlight.c > > +++ b/drivers/hid/hid-picolcd_backlight.c > > @@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data) > > struct backlight_device *bdev =3D data->backlight; > > =20 > > data->backlight =3D NULL; > > - if (bdev) > > - backlight_device_unregister(bdev); > > + backlight_device_unregister(bdev); > > } > > =20 > > int picolcd_resume_backlight(struct picolcd_data *data) > > diff --git a/drivers/hid/hid-picolcd_cir.c b/drivers/hid/hid-picolcd_ci= r.c > > index 045f8eb..9628651 100644 > > --- a/drivers/hid/hid-picolcd_cir.c > > +++ b/drivers/hid/hid-picolcd_cir.c > > @@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data) > > struct rc_dev *rdev =3D data->rc_dev; > > =20 > > data->rc_dev =3D NULL; > > - if (rdev) > > - rc_unregister_device(rdev); > > + rc_unregister_device(rdev); > > } > > =20 > > diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lc= d.c > > index 89821c2..22dcbe1 100644 > > --- a/drivers/hid/hid-picolcd_lcd.c > > +++ b/drivers/hid/hid-picolcd_lcd.c > > @@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data) > > struct lcd_device *ldev =3D data->lcd; > > =20 > > data->lcd =3D NULL; > > - if (ldev) > > - lcd_device_unregister(ldev); > > + lcd_device_unregister(ldev); > > } > > =20 > > int picolcd_resume_lcd(struct picolcd_data *data) > >=20 >=20 > Would you like to integrate this update suggestion > into another source code repository? Sorry for forgetting about this patch. Looks good to me: Reviewed-by: Bruno Pr=C3=A9mont Jiri, can you take it? Best regards, Bruno > Regards, > Markus -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html