From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Fri, 03 Jul 2015 16:28:13 +0000 Subject: Re: [PATCH] net-RDS: Delete an unnecessary check before the function call "module_put" Message-Id: <20150703.092813.145273282420775033.davem@davemloft.net> List-Id: References: <5317A59D.4@users.sourceforge.net> <559561F3.2040107@users.sourceforge.net> In-Reply-To: <559561F3.2040107@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: elfring@users.sourceforge.net Cc: chien.yen@oracle.com, rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr From: SF Markus Elfring Date: Thu, 02 Jul 2015 18:08:19 +0200 > From: Markus Elfring > Date: Thu, 2 Jul 2015 17:58:21 +0200 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied.