From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 09 Jul 2015 01:41:02 +0000 Subject: Re: [PATCH] net-ipvs: Delete an unnecessary check before the function call "module_put" Message-Id: <20150709014102.GB14843@verge.net.au> List-Id: References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BA253.6030100@users.sourceforge.net> <20141119134040.GA12270@salvia> <55955471.9000501@users.sourceforge.net> In-Reply-To: <55955471.9000501@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: "David S. Miller" , Jozsef Kadlecsik , Julian Anastasov , Pablo Neira Ayuso , Patrick McHardy , Wensong Zhang , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall On Thu, Jul 02, 2015 at 05:10:41PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 2 Jul 2015 17:00:14 +0200 > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. Thanks, applied to ipvs-next for v4.3.