From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 09 Jul 2015 08:18:52 +0000 Subject: Re: [PATCH] i2c-HID: Delete unnecessary checks before the function call "gpiod_put" Message-Id: <20150709075813.GQ4341@mwanda> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <559D8874.7090407@users.sourceforge.net> In-Reply-To: <559D8874.7090407@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Jiri Kosina , linux-input@vger.kernel.org, Linux Kernel Mailing List , kernel-janitors@vger.kernel.org, Julia Lawall This one deserves some extra review because it introduces a call to: WARN_ON(extra_checks); in gpiod_free(). That may or may not matter... regards, dan carpenter