From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Date: Wed, 21 Oct 2015 23:15:28 +0000 Subject: Re: [PATCH 3/5] clk: imx27: add missing of_node_put Message-Id: <20151021231528.GJ19782@codeaurora.org> List-Id: References: <1445460100-26727-1-git-send-email-Julia.Lawall@lip6.fr> <1445460100-26727-4-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1445460100-26727-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 10/21, Julia Lawall wrote: > for_each_compatible_node performs an of_node_get on each iteration, so a > break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > local idexpression n; > expression e; > @@ > > for_each_compatible_node(n,...) { > ... > ( > of_node_put(n); > | > e = n > | > + of_node_put(n); > ? break; > ) > ... > } > ... when != n > // > > Signed-off-by: Julia Lawall > > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project