From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] rt2x00: type bug in _rt2500usb_register_read()
Date: Thu, 26 Nov 2015 13:52:42 +0000 [thread overview]
Message-ID: <20151126135241.GA3111@redhat.com> (raw)
In-Reply-To: <20151126115523.GD10556@mwanda>
On Thu, Nov 26, 2015 at 02:55:23PM +0300, Dan Carpenter wrote:
> This code causes a static checker bug.
>
> drivers/net/wireless/ralink/rt2x00/rt2500usb.c:232 _rt2500usb_register_read()
> warn: passing casted pointer 'value' to 'rt2500usb_register_read()' 32 vs 16.
>
> If the low 16 bits were initialized to zero then this code would only be
> a problem on big endian systems. But in this case this is case the low
> 16 bits are never initialized. This is called from a function which is
> created using a macro:
>
> RT2X00DEBUGFS_OPS(csr, "0x%.8x\n", u32);
>
> We end up copying uninitialized data to the user which is bogus and an
> information leak.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
> ---
> Not tested. Perhaps we should just remove this code since it has never
> worked.
It is used for debugfs interface and I would like to keep it.
Stanislaw
next prev parent reply other threads:[~2015-11-26 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 11:55 [patch] rt2x00: type bug in _rt2500usb_register_read() Dan Carpenter
2015-11-26 12:21 ` walter harms
2015-11-26 12:36 ` Dan Carpenter
2015-11-26 13:52 ` Stanislaw Gruszka [this message]
2015-11-30 12:58 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126135241.GA3111@redhat.com \
--to=sgruszka@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=helmut.schaa@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).