* [patch] mwifiex: remove an unneeded condition
@ 2015-12-04 13:17 Dan Carpenter
2015-12-11 11:17 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-12-04 13:17 UTC (permalink / raw)
To: Amitkumar Karwar
Cc: Nishant Sarmukadam, Kalle Valo, linux-wireless, kernel-janitors
We already know that "wep_key->key_length" is set so there is no need to
check again. Also the last curly brace was indented too far.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index a6c8a4f..80f5064 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -923,9 +923,8 @@ static int mwifiex_sec_ioctl_set_wep_key(struct mwifiex_private *priv,
if (encrypt_key->key_disable) {
memset(&priv->wep_key[index], 0,
sizeof(struct mwifiex_wep_key));
- if (wep_key->key_length)
- goto done;
- }
+ goto done;
+ }
if (adapter->key_api_major_ver = KEY_API_VER_MAJOR_V2)
enc_key = encrypt_key;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: mwifiex: remove an unneeded condition
2015-12-04 13:17 [patch] mwifiex: remove an unneeded condition Dan Carpenter
@ 2015-12-11 11:17 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2015-12-11 11:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Amitkumar Karwar, Nishant Sarmukadam, linux-wireless, kernel-janitors
> We already know that "wep_key->key_length" is set so there is no need to
> check again. Also the last curly brace was indented too far.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-11 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-04 13:17 [patch] mwifiex: remove an unneeded condition Dan Carpenter
2015-12-11 11:17 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).