kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bpf: constify bpf_verifier_ops structure
Date: Fri, 11 Dec 2015 18:12:56 +0000	[thread overview]
Message-ID: <20151211131256.41097162@gandalf.local.home> (raw)
In-Reply-To: <1449855359-13724-1-git-send-email-Julia.Lawall@lip6.fr>

On Fri, 11 Dec 2015 18:35:59 +0100
Julia Lawall <Julia.Lawall@lip6.fr> wrote:

> This bpf_verifier_ops structure is never modified, like the other
> bpf_verifier_ops structures, so declare it as const.
> 
> Done with the help of Coccinelle.

Thanks, I'll add this to my 4.5 queue.

-- Steve

> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---
>  kernel/trace/bpf_trace.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index 4228fd3..45dd798 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -316,7 +316,7 @@ static bool kprobe_prog_is_valid_access(int off, int size, enum bpf_access_type
>  	return true;
>  }
>  
> -static struct bpf_verifier_ops kprobe_prog_ops = {
> +static const struct bpf_verifier_ops kprobe_prog_ops = {
>  	.get_func_proto  = kprobe_prog_func_proto,
>  	.is_valid_access = kprobe_prog_is_valid_access,
>  };


  reply	other threads:[~2015-12-11 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-11 17:35 Julia Lawall
2015-12-11 18:12 ` Steven Rostedt [this message]
2015-12-11 18:19   ` Alexei Starovoitov
2015-12-11 18:18 ` Daniel Borkmann
2015-12-11 18:18 ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151211131256.41097162@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --subject='Re: [PATCH] bpf: constify bpf_verifier_ops structure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox