From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Date: Wed, 16 Dec 2015 14:53:43 +0000 Subject: Re: [patch] ASoC: Intel: Skylake: pointer math issue Message-Id: <20151216144143.GM1854@localhost> List-Id: References: <20151208055321.GA5597@mwanda> <20151209160213.GE1854@localhost> In-Reply-To: <20151209160213.GE1854@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jeeja KP , "Subhransu S. Prusty" , Hardik T Shah , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org On Wed, Dec 09, 2015 at 09:32:13PM +0530, Vinod Koul wrote: > On Tue, Dec 08, 2015 at 08:53:22AM +0300, Dan Carpenter wrote: > > "data" is a u32 pointer so this copies the information to wrong place > > entirely. > > Thanks this patch makes sense, I will test this tomorrow and get back Sorry this took a little while longer but this works Acked-by: Vinod Koul Tested-by: Dharageswari R > > > > Fixes: 140adfba5280 ('ASoC: Intel: Skylake: Add tlv byte kcontrols') > > Signed-off-by: Dan Carpenter > > > > diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c > > index dde8d3c..2c4405e 100644 > > --- a/sound/soc/intel/skylake/skl-topology.c > > +++ b/sound/soc/intel/skylake/skl-topology.c > > @@ -885,9 +885,9 @@ static int skl_tplg_tlv_control_get(struct snd_kcontrol *kcontrol, > > if (bc->params) { > > if (copy_to_user(data, &bc->param_id, sizeof(u32))) > > return -EFAULT; > > - if (copy_to_user(data + sizeof(u32), &size, sizeof(u32))) > > + if (copy_to_user(data + 1, &size, sizeof(u32))) > > return -EFAULT; > > - if (copy_to_user(data + 2 * sizeof(u32), bc->params, size)) > > + if (copy_to_user(data + 2, bc->params, size)) > > return -EFAULT; > > } > > > > -- > ~Vinod -- ~Vinod