From: Yuval Shaia <yuval.shaia@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
David Ahern <dsa@cumulusnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Erez Shitrit <erezsh@mellanox.com>,
Feras Daoud <ferasda@mellanox.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Mark Bloch <markb@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>,
Sean Hefty <sean.hefty@intel.com>,
Zhu Yanjun <yanjun.zhu@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 5/9] IB/IPoIB: Combine substrings for three messages
Date: Tue, 18 Apr 2017 11:33:41 +0000 [thread overview]
Message-ID: <20170418113340.GE4045@yuval-lap> (raw)
In-Reply-To: <8267b19e-d6a6-ac77-6b0e-e184e690db9b@users.sourceforge.net>
On Fri, Apr 07, 2017 at 11:05:23PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 7 Apr 2017 21:06:08 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: quoted string split across lines
>
> Thus fix affected source code places.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 55581417eb43..43aef0ca53ad 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -226,8 +226,9 @@ static int ipoib_change_mtu(struct net_device *dev, int new_mtu)
> priv->admin_mtu = new_mtu;
>
> if (priv->mcast_mtu < priv->admin_mtu)
> - ipoib_dbg(priv, "MTU must be smaller than the underlying "
> - "link layer MTU - 4 (%u)\n", priv->mcast_mtu);
> + ipoib_dbg(priv,
> + "MTU must be smaller than the underlying link layer MTU - 4 (%u)\n",
> + priv->mcast_mtu);
>
> dev->mtu = min(priv->mcast_mtu, priv->admin_mtu);
>
> @@ -480,8 +481,8 @@ int ipoib_set_mode(struct net_device *dev, const char *buf)
> /* flush paths if we switch modes so that connections are restarted */
> if (IPOIB_CM_SUPPORTED(dev->dev_addr) && !strcmp(buf, "connected\n")) {
> set_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags);
> - ipoib_warn(priv, "enabling connected mode "
> - "will cause multicast packet drops\n");
> + ipoib_warn(priv,
> + "enabling connected mode will cause multicast packet drops\n");
> netdev_update_features(dev);
> dev_set_mtu(dev, ipoib_cm_max_mtu(dev));
> rtnl_unlock();
> @@ -1855,8 +1856,8 @@ void ipoib_set_umcast(struct net_device *ndev, int umcast_val)
>
> if (umcast_val > 0) {
> set_bit(IPOIB_FLAG_UMCAST, &priv->flags);
> - ipoib_warn(priv, "ignoring multicast groups joined directly "
> - "by userspace\n");
> + ipoib_warn(priv,
> + "ignoring multicast groups joined directly by userspace\n");
> } else
> clear_bit(IPOIB_FLAG_UMCAST, &priv->flags);
> }
> --
> 2.12.2
>
next prev parent reply other threads:[~2017-04-18 11:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 20:54 [PATCH 0/9] InfiniBand-ULP: Fine-tuning for several function implementations SF Markus Elfring
2017-04-07 20:57 ` [PATCH 1/9] IB/IPoIB: Use kcalloc() in two functions SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
[not found] ` <ce4249f2-c7e7-0282-2cff-3f9c3991efa3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-07 21:00 ` [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:03 ` [PATCH 4/9] IB/IPoIB: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:06 ` [PATCH 6/9] IB/iser: Use kmalloc_array() in iser_alloc_rx_descriptors() SF Markus Elfring
[not found] ` <75e5726b-d75f-1b79-1242-08f6440e1691-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-09 9:01 ` Sagi Grimberg
2017-04-07 21:08 ` [PATCH 8/9] IB/isert: Use kcalloc() in isert_alloc_rx_descriptors() SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
2017-04-07 21:01 ` [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:05 ` [PATCH 5/9] IB/IPoIB: Combine substrings for three messages SF Markus Elfring
2017-04-18 11:33 ` Yuval Shaia [this message]
2017-04-07 21:07 ` [PATCH 7/9] IB/iser: Add spaces for better code readability SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
2017-04-07 21:09 ` [PATCH 9/9] IB/isert: Improve size determinations in three functions SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418113340.GE4045@yuval-lap \
--to=yuval.shaia@oracle.com \
--cc=dledford@redhat.com \
--cc=dsa@cumulusnetworks.com \
--cc=elfring@users.sourceforge.net \
--cc=erezsh@mellanox.com \
--cc=ferasda@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=pabeni@redhat.com \
--cc=roid@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sean.hefty@intel.com \
--cc=target-devel@vger.kernel.org \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).