kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ASoC: fix return value check in mt6351_codec_driver_probe()
@ 2018-05-07  1:39 Wei Yongjun
  2018-05-09  8:36 ` Applied "ASoC: fix return value check in mt6351_codec_driver_probe()" to the asoc tree Mark Brown
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Wei Yongjun @ 2018-05-07  1:39 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	Matthias Brugger, Kai Chieh Chuang
  Cc: alsa-devel, kernel-janitors, linux-kernel, linux-mediatek,
	Wei Yongjun, linux-arm-kernel

In case of error, the function dev_get_regmap() returns NULL pointer not
ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 sound/soc/codecs/mt6351.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/mt6351.c b/sound/soc/codecs/mt6351.c
index e739f07..f73dcd7 100644
--- a/sound/soc/codecs/mt6351.c
+++ b/sound/soc/codecs/mt6351.c
@@ -1472,8 +1472,8 @@ static int mt6351_codec_driver_probe(struct platform_device *pdev)
 	priv->dev = &pdev->dev;
 
 	priv->regmap = dev_get_regmap(pdev->dev.parent, NULL);
-	if (IS_ERR(priv->regmap))
-		return PTR_ERR(priv->regmap);
+	if (!priv->regmap)
+		return -ENODEV;
 
 	dev_dbg(priv->dev, "%s(), dev name %s\n",
 		__func__, dev_name(&pdev->dev));




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-09  9:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07  1:39 [PATCH -next] ASoC: fix return value check in mt6351_codec_driver_probe() Wei Yongjun
2018-05-09  8:36 ` Applied "ASoC: fix return value check in mt6351_codec_driver_probe()" to the asoc tree Mark Brown
2018-05-09  9:11 ` Mark Brown
2018-05-09  9:32 ` Mark Brown
2018-05-09  9:47 ` Mark Brown

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox