From: Colin King <colin.king@canonical.com>
To: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz
Date: Thu, 07 May 2020 15:16:10 +0000 [thread overview]
Message-ID: <20200507151610.52636-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
The variable rcqe_sz is being unnecessarily assigned twice, fix this
by removing one of the duplicates.
Addresses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/hw/mlx5/qp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index e5891d3da945..0d292d93f5e7 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2043,8 +2043,7 @@ static int create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
if ((qp->flags_en & MLX5_QP_FLAG_SCATTER_CQE) &&
(init_attr->qp_type = IB_QPT_RC ||
init_attr->qp_type = IB_QPT_UC)) {
- int rcqe_sz = rcqe_sz - mlx5_ib_get_cqe_size(init_attr->recv_cq);
+ int rcqe_sz = mlx5_ib_get_cqe_size(init_attr->recv_cq);
MLX5_SET(qpc, qpc, cs_res,
rcqe_sz = 128 ? MLX5_RES_SCAT_DATA64_CQE :
--
2.25.1
next reply other threads:[~2020-05-07 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 15:16 Colin King [this message]
2020-05-07 18:24 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz Leon Romanovsky
2020-05-08 0:04 ` Jason Gunthorpe
2020-06-04 14:39 ` [PATCH][next] RDMA/mlx5: remove duplicated assignment to resp.response_length Colin King
2020-06-07 6:40 ` Leon Romanovsky
2020-06-15 18:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507151610.52636-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).