From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: "Dan Carpenter" <dan.carpenter@oracle.com>,
linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Namjae Jeon" <namjae.jeon@samsung.com>,
"Sungjong Seo" <sj1557.seo@samsung.com>,
"Pali Rohár" <pali@kernel.org>,
"Tetsuhiro Kohada" <kohada.t2@gmail.com>,
"Wei Yongjun" <weiyongjun1@huawei.com>
Subject: Re: [PATCH v2] exfat: add missing brelse() calls on error paths
Date: Wed, 10 Jun 2020 19:22:44 +0000 [thread overview]
Message-ID: <20200610192244.GK19604@bombadil.infradead.org> (raw)
In-Reply-To: <b44caf20-d3fc-30ac-f716-2375ed55dc9a@web.de>
On Wed, Jun 10, 2020 at 08:56:26PM +0200, Markus Elfring wrote:
> >>> If the second exfat_get_dentry() call fails then we need to release
> >>> "old_bh" before returning. There is a similar bug in exfat_move_file().
> >>
> >> Would you like to convert any information from this change description
> >> into an imperative wording?
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id[14671be58d0084e7e2d1cc9c2c36a94467f6e0#n151
> >
> > I really feel like imperative doesn't add anything. I understand that
> > some people feel really strongly about it, but I don't know why. It
> > doesn't make commit messages more understandable.
>
> Do you insist to deviate from the given guideline?
>
>
> > The important thing is that the problem is clear, the fix is clear and
> > the runtime impact is clear.
>
> I have got further ideas to improve also this commit message.
> I am curious if other contributors would like to add another bit of
> patch review.
You're nitpicking commit messages. This is exactly the kind of thing
which drives people away. Dan's commit message is fine.
It's actually hilarious because your emails are so unclear that I
can't understand them. I have no idea what "collateral evolution"
means and yet you use it in almost every email. Why can't you use the
same terminology the rest of us use?
next prev parent reply other threads:[~2020-06-10 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-08 15:07 [PATCH] exfat: Fix use after free in exfat_load_upcase_table() Markus Elfring
2020-06-08 15:52 ` Matthew Wilcox
2020-06-08 20:07 ` Markus Elfring
2020-06-09 9:10 ` [PATCH] " Greg KH
2020-06-10 9:27 ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10 9:59 ` [PATCH] exfat: call brelse() on error path Dan Carpenter
2020-06-10 12:07 ` Markus Elfring
2020-06-10 17:22 ` [PATCH v2] exfat: add missing brelse() calls on error paths Dan Carpenter
2020-06-10 18:12 ` Markus Elfring
2020-06-10 18:45 ` Dan Carpenter
2020-06-10 18:56 ` Markus Elfring
2020-06-10 19:22 ` Matthew Wilcox [this message]
2020-06-10 20:00 ` Markus Elfring
2020-06-11 3:41 ` [PATCH v2] " Namjae Jeon
2020-06-11 8:00 ` Markus Elfring
2020-06-11 8:40 ` Markus Elfring
2020-06-10 12:14 ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10 14:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610192244.GK19604@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kohada.t2@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pali@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).